2018-12-13 02:30:35

by Ryder Lee

Subject: [PATCH v1] pinctrl: mediatek: improve Kconfig dependencies

Remove prompts to make all pinctrl cores to non-visible symbols and
make sure the target SoCs would be coupled with the corresponding
cores.

Signed-off-by: Ryder Lee <[email protected]>
---
Changes since v1:
- Revise commit message
- Change all pinctrl cores to non-visible symbols
- Drop EINT_MTK in PINCTRL_MTK_MOORE
---
drivers/pinctrl/mediatek/Kconfig | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig
index d8cb584..1817786 100644
--- a/drivers/pinctrl/mediatek/Kconfig
+++ b/drivers/pinctrl/mediatek/Kconfig
@@ -17,7 +17,7 @@ config PINCTRL_MTK
select OF_GPIO

config PINCTRL_MTK_MOORE
- bool "MediaTek Moore Core that implements generic binding"
+ bool
depends on OF
select GENERIC_PINCONF
select GENERIC_PINCTRL_GROUPS
@@ -26,7 +26,7 @@ config PINCTRL_MTK_MOORE
select OF_GPIO

config PINCTRL_MTK_PARIS
- bool "MediaTek Paris Core that implements vendor binding"
+ bool
depends on OF
select PINMUX
select GENERIC_PINCONF
@@ -45,14 +45,14 @@ config PINCTRL_MT2701
config PINCTRL_MT7623
bool "Mediatek MT7623 pin control with generic binding"
depends on MACH_MT7623 || COMPILE_TEST
- depends on PINCTRL_MTK_MOORE
- default y
+ default MACH_MT7623
+ select PINCTRL_MTK_MOORE

config PINCTRL_MT7629
bool "Mediatek MT7629 pin control"
depends on MACH_MT7629 || COMPILE_TEST
- depends on PINCTRL_MTK_MOORE
- default y
+ default MACH_MT7629
+ select PINCTRL_MTK_MOORE

config PINCTRL_MT8135
bool "Mediatek MT8135 pin control"
@@ -93,8 +93,8 @@ config PINCTRL_MT6797
config PINCTRL_MT7622
bool "MediaTek MT7622 pin control"
depends on ARM64 || COMPILE_TEST
- depends on PINCTRL_MTK_MOORE
- default y
+ default ARM64 && ARCH_MEDIATEK
+ select PINCTRL_MTK_MOORE

config PINCTRL_MT8173
bool "Mediatek MT8173 pin control"
--
1.9.1

2018-12-13 04:23:58

by Sean Wang

Subject: Re: [PATCH v1] pinctrl: mediatek: improve Kconfig dependencies

It looks good to me. Thanks for bringing the improved version soon.

Acked-by: Sean Wang <[email protected]>

On Wed, Dec 12, 2018 at 6:28 PM Ryder Lee <[email protected]> wrote:
>
> Remove prompts to make all pinctrl cores to non-visible symbols and
> make sure the target SoCs would be coupled with the corresponding
> cores.
>
> Signed-off-by: Ryder Lee <[email protected]>
> ---
> Changes since v1:
> - Revise commit message
> - Change all pinctrl cores to non-visible symbols
> - Drop EINT_MTK in PINCTRL_MTK_MOORE
> ---
> drivers/pinctrl/mediatek/Kconfig | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig
> index d8cb584..1817786 100644
> --- a/drivers/pinctrl/mediatek/Kconfig
> +++ b/drivers/pinctrl/mediatek/Kconfig
> @@ -17,7 +17,7 @@ config PINCTRL_MTK
> select OF_GPIO
>
> config PINCTRL_MTK_MOORE
> - bool "MediaTek Moore Core that implements generic binding"
> + bool
> depends on OF
> select GENERIC_PINCONF
> select GENERIC_PINCTRL_GROUPS
> @@ -26,7 +26,7 @@ config PINCTRL_MTK_MOORE
> select OF_GPIO
>
> config PINCTRL_MTK_PARIS
> - bool "MediaTek Paris Core that implements vendor binding"
> + bool
> depends on OF
> select PINMUX
> select GENERIC_PINCONF
> @@ -45,14 +45,14 @@ config PINCTRL_MT2701
> config PINCTRL_MT7623
> bool "Mediatek MT7623 pin control with generic binding"
> depends on MACH_MT7623 || COMPILE_TEST
> - depends on PINCTRL_MTK_MOORE
> - default y
> + default MACH_MT7623
> + select PINCTRL_MTK_MOORE
>
> config PINCTRL_MT7629
> bool "Mediatek MT7629 pin control"
> depends on MACH_MT7629 || COMPILE_TEST
> - depends on PINCTRL_MTK_MOORE
> - default y
> + default MACH_MT7629
> + select PINCTRL_MTK_MOORE
>
> config PINCTRL_MT8135
> bool "Mediatek MT8135 pin control"
> @@ -93,8 +93,8 @@ config PINCTRL_MT6797
> config PINCTRL_MT7622
> bool "MediaTek MT7622 pin control"
> depends on ARM64 || COMPILE_TEST
> - depends on PINCTRL_MTK_MOORE
> - default y
> + default ARM64 && ARCH_MEDIATEK
> + select PINCTRL_MTK_MOORE
>
> config PINCTRL_MT8173
> bool "Mediatek MT8173 pin control"
> --
> 1.9.1
>

2018-12-13 16:50:59

by Kevin Hilman

Subject: Re: [PATCH v1] pinctrl: mediatek: improve Kconfig dependencies

Ryder Lee <[email protected]> writes:

> Remove prompts to make all pinctrl cores to non-visible symbols and
> make sure the target SoCs would be coupled with the corresponding
> cores.
>
> Signed-off-by: Ryder Lee <[email protected]>

Tested-by: Kevin Hilman <[email protected]>

Tested on the mt7623-rfb1 board which has been failing in kernelCI, and
this patch gets things booting again.

Kevin

2018-12-21 19:08:29

by Linus Walleij

Subject: Re: [PATCH v1] pinctrl: mediatek: improve Kconfig dependencies

On Thu, Dec 13, 2018 at 3:28 AM Ryder Lee <[email protected]> wrote:

> Remove prompts to make all pinctrl cores to non-visible symbols and
> make sure the target SoCs would be coupled with the corresponding
> cores.
>
> Signed-off-by: Ryder Lee <[email protected]>

Patch applied with ACK and Tested-by.

Yours,
Linus Walleij

2019-01-22 14:03:37

by Ryder Lee

Subject: Re: [PATCH v1] pinctrl: mediatek: improve Kconfig dependencies

CC: [email protected]

On Fri, 2018-12-21 at 18:17 +0800, Linus Walleij wrote:
> On Thu, Dec 13, 2018 at 3:28 AM Ryder Lee <[email protected]> wrote:
>
> > Remove prompts to make all pinctrl cores to non-visible symbols and
> > make sure the target SoCs would be coupled with the corresponding
> > cores.
> >
> > Signed-off-by: Ryder Lee <[email protected]>
>
> Patch applied with ACK and Tested-by.
>
> Yours,
> Linus Walleij

I forgot to add stable-kernel into CC list.
This patch should be applied to stable-rc linux-4.20.y.

Sorry for the inconvenience.
Ryder