2023-05-18 11:01:03

by Prathu Baronia

Subject: [PATCH] arm: omap1: replace printk() with pr_err macro

Use pr_err() macro instead of printk(KERN_ERR "...").

Signed-off-by: Prathu Baronia <[email protected]>
---
arch/arm/mach-omap1/pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-omap1/pm.c b/arch/arm/mach-omap1/pm.c
index 9761d8404949..6a5815aa05e6 100644
--- a/arch/arm/mach-omap1/pm.c
+++ b/arch/arm/mach-omap1/pm.c
@@ -632,7 +632,7 @@ static int __init omap_pm_init(void)

error = sysfs_create_file(power_kobj, &sleep_while_idle_attr.attr);
if (error)
- printk(KERN_ERR "sysfs_create_file failed: %d\n", error);
+ pr_err("sysfs_create_file failed: %d\n", error);

if (cpu_is_omap16xx()) {
/* configure LOW_PWR pin */
--
2.25.1

2023-05-19 18:19:30

by Kevin Hilman

Subject: Re: [PATCH] arm: omap1: replace printk() with pr_err macro

Prathu Baronia <[email protected]> writes:

> Use pr_err() macro instead of printk(KERN_ERR "...").
>
> Signed-off-by: Prathu Baronia <[email protected]>

Acked-by: Kevin Hilman <[email protected]>

> ---
> arch/arm/mach-omap1/pm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap1/pm.c b/arch/arm/mach-omap1/pm.c
> index 9761d8404949..6a5815aa05e6 100644
> --- a/arch/arm/mach-omap1/pm.c
> +++ b/arch/arm/mach-omap1/pm.c
> @@ -632,7 +632,7 @@ static int __init omap_pm_init(void)
>
> error = sysfs_create_file(power_kobj, &sleep_while_idle_attr.attr);
> if (error)
> - printk(KERN_ERR "sysfs_create_file failed: %d\n", error);
> + pr_err("sysfs_create_file failed: %d\n", error);
>
> if (cpu_is_omap16xx()) {
> /* configure LOW_PWR pin */
> --
> 2.25.1

2023-05-31 06:20:36

by Tony Lindgren

Subject: Re: [PATCH] arm: omap1: replace printk() with pr_err macro

* Prathu Baronia <[email protected]> [230518 13:34]:
> Use pr_err() macro instead of printk(KERN_ERR "...").

Thanks applying into omap-for-v6.5/cleanup.

Tony