2020-12-28 16:38:43

by Alexander Dahl

Subject: [PATCH v9 4/4] arm64: dts: meson: Fix schema warnings for pwm-leds

The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.

Signed-off-by: Alexander Dahl <[email protected]>
Reviewed-by: Neil Armstrong <[email protected]>
---

Notes:
v8 -> v9:
* rebased on v5.11-rc1

v7 -> v8:
* rebased on pavel/for-next (post v5.10-rc1)

v6 -> v7:
* added Reviewed-by
* added another explaining sentence to commit message

v6:
* added this patch to series

.../arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts | 4 ++--
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 ++--
arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts | 8 ++++----
3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
index 6fe589cd2ba2..45adae480a3d 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
@@ -42,10 +42,10 @@
};
};

- pwmleds {
+ led-controller {
compatible = "pwm-leds";

- power {
+ led-1 {
label = "vim:red:power";
pwms = <&pwm_AO_ab 1 7812500 0>;
max-brightness = <255>;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
index bf9877d33427..25857e0c0831 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
@@ -81,10 +81,10 @@
};
};

- pwmleds {
+ led-controller {
compatible = "pwm-leds";

- power {
+ led-1 {
label = "vim:red:power";
pwms = <&pwm_AO_ab 1 7812500 0>;
max-brightness = <255>;
diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
index 5ab139a34c01..039a8d0d1e9b 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
@@ -101,20 +101,20 @@
};
};

- leds {
+ led-controller-1 {
compatible = "gpio-leds";

- led-bluetooth {
+ led-1 {
label = "sei610:blue:bt";
gpios = <&gpio GPIOC_7 (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
default-state = "off";
};
};

- pwmleds {
+ led-controller-2 {
compatible = "pwm-leds";

- power {
+ led-2 {
label = "sei610:red:power";
pwms = <&pwm_AO_ab 0 30518 0>;
max-brightness = <255>;
--
2.20.1

2021-01-04 16:19:38

by Kevin Hilman

Subject: Re: [PATCH v9 4/4] arm64: dts: meson: Fix schema warnings for pwm-leds

Alexander Dahl <[email protected]> writes:

> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now). Parent node name is not enforced, but recommended
> by DT project.
>
> Signed-off-by: Alexander Dahl <[email protected]>
> Reviewed-by: Neil Armstrong <[email protected]>

Queued for 5.12,

Thanks,

Kevin