2020-08-31 10:27:55

by Wolfram Sang

Subject: [PATCH] mmc: meson-gx: use wrapper to avoid accessing internal vars

Signed-off-by: Wolfram Sang <[email protected]>
---

Only buildtested. Found while analyzing retune-handling in the core.

drivers/mmc/host/meson-gx-mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 08a3b1c05acb..a1db8685e30e 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -521,7 +521,7 @@ static int meson_mmc_resampling_tuning(struct mmc_host *mmc, u32 opcode)
val |= ADJUST_ADJ_EN;
writel(val, host->regs + host->data->adjust);

- if (mmc->doing_retune)
+ if (mmc_doing_retune(mmc))
dly = FIELD_GET(ADJUST_ADJ_DELAY_MASK, val) + 1;
else
dly = 0;
--
2.20.1

2020-08-31 22:34:07

by Kevin Hilman

Subject: Re: [PATCH] mmc: meson-gx: use wrapper to avoid accessing internal vars

Wolfram Sang <[email protected]> writes:

> Signed-off-by: Wolfram Sang <[email protected]>

Reviewed-by: Kevin Hilman <[email protected]>

> ---
>
> Only buildtested. Found while analyzing retune-handling in the core.
>
> drivers/mmc/host/meson-gx-mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 08a3b1c05acb..a1db8685e30e 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -521,7 +521,7 @@ static int meson_mmc_resampling_tuning(struct mmc_host *mmc, u32 opcode)
> val |= ADJUST_ADJ_EN;
> writel(val, host->regs + host->data->adjust);
>
> - if (mmc->doing_retune)
> + if (mmc_doing_retune(mmc))
> dly = FIELD_GET(ADJUST_ADJ_DELAY_MASK, val) + 1;
> else
> dly = 0;
> --
> 2.20.1

2020-09-02 09:06:21

by Ulf Hansson

Subject: Re: [PATCH] mmc: meson-gx: use wrapper to avoid accessing internal vars

On Mon, 31 Aug 2020 at 12:23, Wolfram Sang
<[email protected]> wrote:
>
> Signed-off-by: Wolfram Sang <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


> ---
>
> Only buildtested. Found while analyzing retune-handling in the core.
>
> drivers/mmc/host/meson-gx-mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 08a3b1c05acb..a1db8685e30e 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -521,7 +521,7 @@ static int meson_mmc_resampling_tuning(struct mmc_host *mmc, u32 opcode)
> val |= ADJUST_ADJ_EN;
> writel(val, host->regs + host->data->adjust);
>
> - if (mmc->doing_retune)
> + if (mmc_doing_retune(mmc))
> dly = FIELD_GET(ADJUST_ADJ_DELAY_MASK, val) + 1;
> else
> dly = 0;
> --
> 2.20.1
>