2019-03-12 08:35:07

by Chuanhong Guo

Subject: [PATCH] arm64: dts: meson-gxl-s905d-phicomm-n1: add status LED

There is a white LED on the front panel behind the logo and the
manufacturer uses that LED to indicate network and USB drive status.

Signed-off-by: Chuanhong Guo <[email protected]>
---
.../boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
index 9a8a8a7e4b53..b5667f1fb2c8 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
@@ -14,6 +14,16 @@
cvbs-connector {
status = "disabled";
};
+
+ leds {
+ compatible = "gpio-leds";
+
+ status {
+ label = "n1:white:status";
+ gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>;
+ default-state = "on";
+ };
+ };
};

&cvbs_vdac_port {
--
2.20.1

2019-03-12 09:00:24

by Neil Armstrong

Subject: Re: [PATCH] arm64: dts: meson-gxl-s905d-phicomm-n1: add status LED

Hi Chuanhong,

On 12/03/2019 09:33, Chuanhong Guo wrote:
> There is a white LED on the front panel behind the logo and the
> manufacturer uses that LED to indicate network and USB drive status.
>
> Signed-off-by: Chuanhong Guo <[email protected]>
> ---
> .../boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
> index 9a8a8a7e4b53..b5667f1fb2c8 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
> @@ -14,6 +14,16 @@
> cvbs-connector {
> status = "disabled";
> };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + status {
> + label = "n1:white:status";
> + gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>;
> + default-state = "on";
> + };
> + };
> };
>
> &cvbs_vdac_port {
>

Reviewed-by: Neil Armstrong <[email protected]>

BTW, do you know if it's possible to have a sample of the Phicomm N1
in order to be added in kernelci ?

Neil

2019-03-12 10:30:08

by Chuanhong Guo

Subject: Re: [PATCH] arm64: dts: meson-gxl-s905d-phicomm-n1: add status LED

Hi!
On Tue, Mar 12, 2019 at 4:59 PM Neil Armstrong <[email protected]> wrote:
> [...]
> BTW, do you know if it's possible to have a sample of the Phicomm N1
> in order to be added in kernelci ?
It's easy to purchase one in China and second-handed ones are dirt
cheap, but I don't think it's available worldwide.
I'm not familiar with world-wide shipping or exporting stuff so I
can't help much here.
>
> Neil

2019-03-14 18:10:26

by Kevin Hilman

Subject: Re: [PATCH] arm64: dts: meson-gxl-s905d-phicomm-n1: add status LED

Neil Armstrong <[email protected]> writes:

> Hi Chuanhong,
>
> On 12/03/2019 09:33, Chuanhong Guo wrote:
>> There is a white LED on the front panel behind the logo and the
>> manufacturer uses that LED to indicate network and USB drive status.
>>
>> Signed-off-by: Chuanhong Guo <[email protected]>
>> ---
>> .../boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
>> index 9a8a8a7e4b53..b5667f1fb2c8 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
>> @@ -14,6 +14,16 @@
>> cvbs-connector {
>> status = "disabled";
>> };
>> +
>> + leds {
>> + compatible = "gpio-leds";
>> +
>> + status {
>> + label = "n1:white:status";
>> + gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>;
>> + default-state = "on";
>> + };
>> + };
>> };
>>
>> &cvbs_vdac_port {
>>
>
> Reviewed-by: Neil Armstrong <[email protected]>

Queued for v5.2 with Neil's tag (branch: v5.2/dt64)

Kevin