2007-05-28 23:11:47

by Junio C Hamano

[permalink] [raw]
Subject: [PATCH 3/3] ide_in_drive_list(): "ALL" is not a wildcard anymore.

This removes the support to treat "ALL" as a wildcard for
firmware revision. This is made a separate patch, as it will
break out-of-tree ide drivers that feed its own table that uses
"ALL" as the wildcard to ide_in_drive_list().

Signed-off-by: Junio C Hamano <[email protected]>
---

* This is a respin of earlier "3/3 Make ide dma blacklist handling a bit saner."

drivers/ide/ide-dma.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/ide/ide-dma.c b/drivers/ide/ide-dma.c
index 230ea12..3107b5e 100644
--- a/drivers/ide/ide-dma.c
+++ b/drivers/ide/ide-dma.c
@@ -148,7 +148,6 @@ int ide_in_drive_list(struct hd_driveid *id, const struct drive_list_entry *driv
for ( ; drive_table->id_model ; drive_table++)
if ((!strcmp(drive_table->id_model, id->model)) &&
(!drive_table->id_firmware ||
- !strcmp(drive_table->id_firmware, "ALL") || /* to be removed later */
strstr(id->fw_rev, drive_table->id_firmware)))
return 1;
return 0;
--
1.5.2.86.g99b5-dirty



Subject: Re: [PATCH 3/3] ide_in_drive_list(): "ALL" is not a wildcard anymore.

On Tuesday 29 May 2007, Junio C Hamano wrote:
> This removes the support to treat "ALL" as a wildcard for
> firmware revision. This is made a separate patch, as it will
> break out-of-tree ide drivers that feed its own table that uses
> "ALL" as the wildcard to ide_in_drive_list().
>
> Signed-off-by: Junio C Hamano <[email protected]>

applied