2006-05-18 08:52:46

by Junio C Hamano

Subject: [WARNING] Please be careful when using "git add" from "next" branch

There is still a small breakage in the built-in "git add" on the
"next" branch that ends up creating nonsense tree objects.

$ mkdir foo
$ date >bar
$ git-add foo/../bar
$ git ls-files
foo/../bar
$ git ls-tree -r -t $(git-write-tree)
040000 tree ef5562cd3a9bf66d41a8d4f42f159e8c694ce7e3 foo
040000 tree 6e1612248e8da43fc5f91592e559da1ad5f9a852 foo/..
100644 blob 53ab446c3f4e42ce9bb728a0ccb283a101be4979 foo/../bar

If you do not do funky things like foo/../bar, I do not think
you have to worry, but scripted use might break. It used to
warn and ignore such bogus input, but now it happily accepts it
and produces bogus index which results in bogus trees.

"git update-index --add" is not affected by this breakage.

2006-05-19 06:28:37

by Junio C Hamano

Subject: FIXED: [WARNING] Please be careful when using "git add" from "next" branch

Junio C Hamano <[email protected]> writes:

> There is still a small breakage in the built-in "git add" on the
> "next" branch that ends up creating nonsense tree objects.

This was fixed this morning, in case I scared people.