2023-03-08 13:20:26

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH v2 resend 3] ahci: qoriq: Add platform dependencies

The Freescale QorIQ AHCI SATA controller is only present on Freescale
Layerscape SoCs. Add platform dependencies to the AHCI_QORIQ config
symbol, to avoid asking the user about it when configuring a kernel
without Layerscape support.

Signed-off-by: Geert Uytterhoeven <[email protected]>
Acked-by: Arnd Bergmann <[email protected]>
Acked-by: Li Yang <[email protected]>
---
v2:
- Add Acked-by.
---
drivers/ata/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index b56fba76b43f48f7..42b51c9812a0ebab 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -276,6 +276,7 @@ config AHCI_XGENE
config AHCI_QORIQ
tristate "Freescale QorIQ AHCI SATA support"
depends on OF
+ depends on SOC_LS1021A || ARCH_LAYERSCAPE || COMPILE_TEST
select SATA_HOST
help
This option enables support for the Freescale QorIQ AHCI SoC's
--
2.34.1



2023-03-14 12:12:54

by Damien Le Moal

[permalink] [raw]
Subject: Re: [PATCH v2 resend 3] ahci: qoriq: Add platform dependencies

On 3/8/23 21:49, Geert Uytterhoeven wrote:
> The Freescale QorIQ AHCI SATA controller is only present on Freescale
> Layerscape SoCs. Add platform dependencies to the AHCI_QORIQ config
> symbol, to avoid asking the user about it when configuring a kernel
> without Layerscape support.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> Acked-by: Arnd Bergmann <[email protected]>
> Acked-by: Li Yang <[email protected]>
> ---
> v2:
> - Add Acked-by.
> ---
> drivers/ata/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index b56fba76b43f48f7..42b51c9812a0ebab 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -276,6 +276,7 @@ config AHCI_XGENE
> config AHCI_QORIQ
> tristate "Freescale QorIQ AHCI SATA support"
> depends on OF
> + depends on SOC_LS1021A || ARCH_LAYERSCAPE || COMPILE_TEST
> select SATA_HOST
> help
> This option enables support for the Freescale QorIQ AHCI SoC's

Do you want this in fixes or queuing this for 6.4 is fine ?

--
Damien Le Moal
Western Digital Research


2023-03-14 13:02:04

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH v2 resend 3] ahci: qoriq: Add platform dependencies

Hi Damien,

On Tue, Mar 14, 2023 at 1:12 PM Damien Le Moal
<[email protected]> wrote:
> On 3/8/23 21:49, Geert Uytterhoeven wrote:
> > The Freescale QorIQ AHCI SATA controller is only present on Freescale
> > Layerscape SoCs. Add platform dependencies to the AHCI_QORIQ config
> > symbol, to avoid asking the user about it when configuring a kernel
> > without Layerscape support.
> >
> > Signed-off-by: Geert Uytterhoeven <[email protected]>
> > Acked-by: Arnd Bergmann <[email protected]>
> > Acked-by: Li Yang <[email protected]>
> > ---
> > v2:
> > - Add Acked-by.
> > ---
> > drivers/ata/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> > index b56fba76b43f48f7..42b51c9812a0ebab 100644
> > --- a/drivers/ata/Kconfig
> > +++ b/drivers/ata/Kconfig
> > @@ -276,6 +276,7 @@ config AHCI_XGENE
> > config AHCI_QORIQ
> > tristate "Freescale QorIQ AHCI SATA support"
> > depends on OF
> > + depends on SOC_LS1021A || ARCH_LAYERSCAPE || COMPILE_TEST
> > select SATA_HOST
> > help
> > This option enables support for the Freescale QorIQ AHCI SoC's
>
> Do you want this in fixes or queuing this for 6.4 is fine ?

I guess 6.4 is fine. We've been seeing this message while configuring
our kernels for years, so a few extra weeks won't hurt ;-)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2023-03-15 01:27:43

by Damien Le Moal

[permalink] [raw]
Subject: Re: [PATCH v2 resend 3] ahci: qoriq: Add platform dependencies

On 3/8/23 21:49, Geert Uytterhoeven wrote:
> The Freescale QorIQ AHCI SATA controller is only present on Freescale
> Layerscape SoCs. Add platform dependencies to the AHCI_QORIQ config
> symbol, to avoid asking the user about it when configuring a kernel
> without Layerscape support.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> Acked-by: Arnd Bergmann <[email protected]>
> Acked-by: Li Yang <[email protected]>

Applied to for-6.4. Thanks !

--
Damien Le Moal
Western Digital Research