2022-12-05 20:35:21

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 4.9 00/62] 4.9.335-rc1 review

This is the start of the stable review cycle for the 4.9.335 release.
There are 62 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.

Responses should be made by Wed, 07 Dec 2022 19:07:46 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.335-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>
Linux 4.9.335-rc1

Adrian Hunter <[email protected]>
mmc: sdhci: Fix voltage switch delay

Masahiro Yamada <[email protected]>
mmc: sdhci: use FIELD_GET for preset value bit masks

Michael Kelley <[email protected]>
x86/ioremap: Fix page aligned size calculation in __ioremap_caller()

Luiz Augusto von Dentz <[email protected]>
Bluetooth: L2CAP: Fix accepting connection request for invalid SPSM

Pawan Gupta <[email protected]>
x86/pm: Add enumeration check before spec MSRs save/restore setup

Pawan Gupta <[email protected]>
x86/tsx: Add a feature bit for TSX control MSR support

Ulrich Hecht <[email protected]>
Revert "fbdev: fb_pm2fb: Avoid potential divide by zero error"

Kuniyuki Iwashima <[email protected]>
tcp/udp: Fix memory leak in ipv6_renew_options().

Xiongfeng Wang <[email protected]>
iommu/vt-d: Fix PCI device refcount leak in dmar_dev_scope_init()

Maxim Korotkov <[email protected]>
pinctrl: single: Fix potential division by zero

Mark Brown <[email protected]>
ASoC: ops: Fix bounds check for _sx controls

James Morse <[email protected]>
arm64: errata: Fix KVM Spectre-v2 mitigation selection for Cortex-A57/A72

James Morse <[email protected]>
arm64: Fix panic() when Spectre-v2 causes Spectre-BHB to re-allocate KVM vectors

ZhangPeng <[email protected]>
nilfs2: fix NULL pointer dereference in nilfs_palloc_commit_free_entry()

Tiezhu Yang <[email protected]>
tools/vm/slabinfo-gnuplot: use "grep -E" instead of "egrep"

ChenXiaoSong <[email protected]>
btrfs: qgroup: fix sleep from invalid context bug in btrfs_qgroup_inherit()

Yang Yingliang <[email protected]>
hwmon: (coretemp) fix pci device refcount leak in nv1a_ram_new()

Phil Auld <[email protected]>
hwmon: (coretemp) Check for null before removing sysfs attrs

Yoshihiro Shimoda <[email protected]>
net: ethernet: renesas: ravb: Fix promiscuous mode after system resumed

Willem de Bruijn <[email protected]>
packet: do not set TP_STATUS_CSUM_VALID on CHECKSUM_COMPLETE

YueHaibing <[email protected]>
net: hsr: Fix potential use-after-free

Wang Hai <[email protected]>
net/9p: Fix a potential socket leak in p9_socket_open

Yuan Can <[email protected]>
net: net_netdev: Fix error handling in ntb_netdev_init_module()

Yang Yingliang <[email protected]>
net: phy: fix null-ptr-deref while probe() failed

Duoming Zhou <[email protected]>
qlcnic: fix sleep-in-atomic-context bugs caused by msleep

Zhang Changzhong <[email protected]>
can: cc770: cc770_isa_probe(): add missing free_cc770dev()

Zhang Changzhong <[email protected]>
can: sja1000_isa: sja1000_isa_probe(): add missing free_sja1000dev()

YueHaibing <[email protected]>
net/mlx5: Fix uninitialized variable bug in outlen_write()

Gaosheng Cui <[email protected]>
hwmon: (ibmpex) Fix possible UAF when ibmpex_register_bmc() fails

Yang Yingliang <[email protected]>
hwmon: (i5500_temp) fix missing pci_disable_device()

Wei Yongjun <[email protected]>
iio: health: afe4404: Fix oob read in afe4404_[read|write]_raw

Wei Yongjun <[email protected]>
iio: health: afe4403: Fix oob read in afe4403_read_raw

Christian König <[email protected]>
drm/amdgpu: always register an MMU notifier for userptr

Enrico Sau <[email protected]>
net: usb: qmi_wwan: add Telit 0x103a composition

Gleb Mazovetskiy <[email protected]>
tcp: configurable source port perturb table size

Xiongfeng Wang <[email protected]>
platform/x86: asus-wmi: add missing pci_dev_put() in asus_wmi_set_xusb2pr()

ruanjinjie <[email protected]>
xen/platform-pci: add missing free_irq() in error path

Lukas Wunner <[email protected]>
serial: 8250: 8250_omap: Avoid RS485 RTS glitch on ->set_termios()

Chen Zhongjin <[email protected]>
nilfs2: fix nilfs_sufile_mark_dirty() not set segment usage as dirty

Randy Dunlap <[email protected]>
nios2: add FORCE for vmlinuz.gz

Masahiro Yamada <[email protected]>
kconfig: display recursive dependency resolution hint just once

Chen Zhongjin <[email protected]>
iio: core: Fix entry not deleted when iio_register_sw_trigger_type() fails

Alejandro Concepción Rodríguez <[email protected]>
iio: light: apds9960: fix wrong register for gesture gain

Heiko Carstens <[email protected]>
s390/crashdump: fix TOD programmable field size

Yu Liao <[email protected]>
net: thunderx: Fix the ACPI memory leak

Martin Faltesek <[email protected]>
nfc: st-nci: fix memory leaks in EVT_TRANSACTION

Martin Faltesek <[email protected]>
nfc: st-nci: fix incorrect validating logic in EVT_TRANSACTION

Liu Shixin <[email protected]>
NFC: nci: fix memory leak in nci_rx_data_packet()

Chen Zhongjin <[email protected]>
xfrm: Fix ignored return value in xfrm6_init()

Zhang Changzhong <[email protected]>
net/qla3xxx: fix potential memleak in ql3xxx_send()

Peter Kosyh <[email protected]>
net/mlx4: Check retval of mlx4_bitmap_init

Zheng Yongjun <[email protected]>
ARM: mxs: fix memory leak in mxs_machine_init()

Zhengchao Shao <[email protected]>
9p/fd: fix issue of list_del corruption in p9_fd_cancel()

Wang Hai <[email protected]>
net: pch_gbe: fix potential memleak in pch_gbe_tx_queue()

Lin Ma <[email protected]>
nfc/nci: fix race with opening and closing

Michael Grzeschik <[email protected]>
ARM: dts: at91: sam9g20ek: enable udc vbus gpio pinctrl

Samuel Holland <[email protected]>
bus: sunxi-rsb: Support atomic transfers

Herbert Xu <[email protected]>
af_key: Fix send_acquire race with pfkey_register

Jason A. Donenfeld <[email protected]>
MIPS: pic32: treat port as signed integer

Nicolas Cavallari <[email protected]>
wifi: mac80211: Fix ack frame idr leak when mesh has no route

Gaosheng Cui <[email protected]>
audit: fix undefined behavior in bit shift for AUDIT_BIT

Jonas Jelonek <[email protected]>
wifi: mac80211_hwsim: fix debugfs attribute ps with rc table support


-------------

Diffstat:

Makefile | 4 +-
arch/arm/boot/dts/at91sam9g20ek_common.dtsi | 9 +++
arch/arm/mach-mxs/mach-mxs.c | 4 +-
arch/arm64/kernel/cpu_errata.c | 25 +++++---
arch/mips/include/asm/fw/fw.h | 2 +-
arch/mips/pic32/pic32mzda/early_console.c | 13 ++--
arch/mips/pic32/pic32mzda/init.c | 2 +-
arch/nios2/boot/Makefile | 2 +-
arch/s390/kernel/crash_dump.c | 2 +-
arch/x86/include/asm/cpufeatures.h | 1 +
arch/x86/kernel/cpu/tsx.c | 33 +++++-----
arch/x86/mm/ioremap.c | 8 ++-
arch/x86/power/cpu.c | 23 ++++---
drivers/bus/sunxi-rsb.c | 29 ++++++---
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 8 +--
drivers/hwmon/coretemp.c | 9 ++-
drivers/hwmon/i5500_temp.c | 2 +-
drivers/hwmon/ibmpex.c | 1 +
drivers/iio/health/afe4403.c | 5 +-
drivers/iio/health/afe4404.c | 12 ++--
drivers/iio/industrialio-sw-trigger.c | 6 +-
drivers/iio/light/apds9960.c | 12 ++--
drivers/iommu/dmar.c | 1 +
drivers/mmc/host/sdhci.c | 71 ++++++++++++++++++----
drivers/mmc/host/sdhci.h | 12 ++--
drivers/net/can/cc770/cc770_isa.c | 10 +--
drivers/net/can/sja1000/sja1000_isa.c | 10 +--
drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 4 +-
drivers/net/ethernet/mellanox/mlx4/qp.c | 3 +-
drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 4 +-
.../net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 1 +
drivers/net/ethernet/qlogic/qla3xxx.c | 1 +
.../net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 4 +-
drivers/net/ethernet/renesas/ravb_main.c | 1 +
drivers/net/ntb_netdev.c | 9 ++-
drivers/net/phy/phy_device.c | 1 +
drivers/net/usb/qmi_wwan.c | 1 +
drivers/net/wireless/mac80211_hwsim.c | 5 ++
drivers/nfc/st-nci/se.c | 6 +-
drivers/pinctrl/pinctrl-single.c | 2 +-
drivers/platform/x86/asus-wmi.c | 2 +
drivers/tty/serial/8250/8250_omap.c | 7 ++-
drivers/video/fbdev/pm2fb.c | 5 --
drivers/xen/platform-pci.c | 7 ++-
fs/btrfs/qgroup.c | 9 +--
fs/nilfs2/dat.c | 7 +++
fs/nilfs2/sufile.c | 8 +++
include/uapi/linux/audit.h | 2 +-
net/9p/trans_fd.c | 6 +-
net/bluetooth/l2cap_core.c | 13 ++++
net/hsr/hsr_forward.c | 5 +-
net/ipv4/Kconfig | 10 +++
net/ipv4/inet_hashtables.c | 10 +--
net/ipv6/ipv6_sockglue.c | 7 +++
net/ipv6/xfrm6_policy.c | 6 +-
net/key/af_key.c | 32 +++++++---
net/mac80211/mesh_pathtbl.c | 2 +-
net/nfc/nci/core.c | 2 +-
net/nfc/nci/data.c | 4 +-
net/packet/af_packet.c | 6 +-
scripts/kconfig/symbol.c | 8 ++-
sound/soc/soc-ops.c | 2 +-
tools/vm/slabinfo-gnuplot.sh | 4 +-
63 files changed, 358 insertions(+), 164 deletions(-)



2022-12-05 22:55:20

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 4.9 00/62] 4.9.335-rc1 review

On 12/5/22 14:28, Jon Hunter wrote:
> Hi Greg,
>
> On 05/12/2022 19:08, Greg Kroah-Hartman wrote:
>> This is the start of the stable review cycle for the 4.9.335 release.
>> There are 62 patches in this series, all will be posted as a response
>> to this one.  If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Wed, 07 Dec 2022 19:07:46 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>>     https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.335-rc1.gz
>> or in the git tree and branch at:
>>     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y
>> and the diffstat can be found below.
>>
>> thanks,
>>
>> greg k-h
>>
>> -------------
>> Pseudo-Shortlog of commits:
>>
>> Greg Kroah-Hartman <[email protected]>
>>      Linux 4.9.335-rc1
>>
>> Adrian Hunter <[email protected]>
>>      mmc: sdhci: Fix voltage switch delay
>
>
> I am seeing a boot regression on a couple boards and bisect is pointing
> to the above commit.

Same thing here, getting a hard lock for our devices with the SDHCI
controller enabled, sometimes we are lucky to see the following:

[ 4.790367] mmc0: SDHCI controller on 84b0000.sdhci [84b0000.sdhci]
using ADMA 64-bit
[ 25.802351] INFO: rcu_sched detected stalls on CPUs/tasks:
[ 25.807871] 1-...: (1 GPs behind) idle=561/140000000000000/0
softirq=728/728 fqs=5252
[ 25.815892] (detected by 0, t=21017 jiffies, g=61, c=60, q=55)
[ 25.821834] Task dump for CPU 1:
[ 25.825069] kworker/1:1 R running task 0 509 2
0x00000002
[ 25.832164] Workqueue: events_freezable mmc_rescan
[ 25.836974] Backtrace:
[ 25.839440] [<ce32fea4>] (0xce32fea4) from [<ce32fed4>] (0xce32fed4)
[ 25.845803] Backtrace aborted due to bad frame pointer <cd2f0a54>

Also confirmed that reverting that change ("mmc: sdhci: Fix voltage
switch delay") allows devices to boot properly.

Had not a chance to test the change when submitted for mainline despite
being copied, sorry about that.

Since that specific commit is also included in the other stable trees
(5.4, 5.10, 5.15 and 6.0) I will let you know whether the same issue is
present in those trees shortly thereafter.
--
Florian

2022-12-05 23:05:59

by Jon Hunter

[permalink] [raw]
Subject: Re: [PATCH 4.9 00/62] 4.9.335-rc1 review

Hi Greg,

On 05/12/2022 19:08, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.9.335 release.
> There are 62 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 07 Dec 2022 19:07:46 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.335-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
> -------------
> Pseudo-Shortlog of commits:
>
> Greg Kroah-Hartman <[email protected]>
> Linux 4.9.335-rc1
>
> Adrian Hunter <[email protected]>
> mmc: sdhci: Fix voltage switch delay


I am seeing a boot regression on a couple boards and bisect is pointing
to the above commit.

Test results for stable-v4.9:
8 builds: 8 pass, 0 fail
20 boots: 16 pass, 4 fail
16 tests: 16 pass, 0 fail

Linux version: 4.9.335-rc1-g9ad972a03b17
Boards tested: tegra124-jetson-tk1, tegra20-ventana,
tegra210-p2371-2180, tegra30-cardhu-a04

Boot failures: tegra124-jetson-tk1, tegra210-p2371-2180

Cheers
Jon

--
nvpublic

2022-12-06 00:29:38

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 4.9 00/62] 4.9.335-rc1 review

On 12/5/22 14:48, Florian Fainelli wrote:
> On 12/5/22 14:28, Jon Hunter wrote:
>> Hi Greg,
>>
>> On 05/12/2022 19:08, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 4.9.335 release.
>>> There are 62 patches in this series, all will be posted as a response
>>> to this one.  If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Wed, 07 Dec 2022 19:07:46 +0000.
>>> Anything received after that time might be too late.
>>>
>>> The whole patch series can be found in one patch at:
>>>     https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.335-rc1.gz
>>> or in the git tree and branch at:
>>>     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y
>>> and the diffstat can be found below.
>>>
>>> thanks,
>>>
>>> greg k-h
>>>
>>> -------------
>>> Pseudo-Shortlog of commits:
>>>
>>> Greg Kroah-Hartman <[email protected]>
>>>      Linux 4.9.335-rc1
>>>
>>> Adrian Hunter <[email protected]>
>>>      mmc: sdhci: Fix voltage switch delay
>>
>>
>> I am seeing a boot regression on a couple boards and bisect is
>> pointing to the above commit.
>
> Same thing here, getting a hard lock for our devices with the SDHCI
> controller enabled, sometimes we are lucky to see the following:
>
> [    4.790367] mmc0: SDHCI controller on 84b0000.sdhci [84b0000.sdhci]
> using ADMA 64-bit
> [   25.802351] INFO: rcu_sched detected stalls on CPUs/tasks:
> [   25.807871]  1-...: (1 GPs behind) idle=561/140000000000000/0
> softirq=728/728 fqs=5252
> [   25.815892]  (detected by 0, t=21017 jiffies, g=61, c=60, q=55)
> [   25.821834] Task dump for CPU 1:
> [   25.825069] kworker/1:1     R  running task        0   509      2
> 0x00000002
> [   25.832164] Workqueue: events_freezable mmc_rescan
> [   25.836974] Backtrace:
> [   25.839440] [<ce32fea4>] (0xce32fea4) from [<ce32fed4>] (0xce32fed4)
> [   25.845803] Backtrace aborted due to bad frame pointer <cd2f0a54>
>
> Also confirmed that reverting that change ("mmc: sdhci: Fix voltage
> switch delay") allows devices to boot properly.
>
> Had not a chance to test the change when submitted for mainline despite
> being copied, sorry about that.
>
> Since that specific commit is also included in the other stable trees
> (5.4, 5.10, 5.15 and 6.0) I will let you know whether the same issue is
> present in those trees shortly thereafter.

This only appears to impact 4.9, Adrian is there a missing functional
dependency for "mmc: sdhci: Fix voltage switch delay" to work correctly
on the 4.9 kernel?
--
Florian

2022-12-06 03:32:42

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH 4.9 00/62] 4.9.335-rc1 review

On 12/5/22 12:08, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.9.335 release.
> There are 62 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 07 Dec 2022 19:07:46 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.335-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>

Compiled and booted on my test system. No dmesg regressions.

Tested-by: Shuah Khan <[email protected]>

thanks,
-- Shuah

2022-12-06 09:46:02

by Adrian Hunter

[permalink] [raw]
Subject: Re: [PATCH 4.9 00/62] 4.9.335-rc1 review

On 6/12/22 02:11, Florian Fainelli wrote:
> On 12/5/22 14:48, Florian Fainelli wrote:
>> On 12/5/22 14:28, Jon Hunter wrote:
>>> Hi Greg,
>>>
>>> On 05/12/2022 19:08, Greg Kroah-Hartman wrote:
>>>> This is the start of the stable review cycle for the 4.9.335 release.
>>>> There are 62 patches in this series, all will be posted as a response
>>>> to this one.  If anyone has any issues with these being applied, please
>>>> let me know.
>>>>
>>>> Responses should be made by Wed, 07 Dec 2022 19:07:46 +0000.
>>>> Anything received after that time might be too late.
>>>>
>>>> The whole patch series can be found in one patch at:
>>>>     https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.335-rc1.gz
>>>> or in the git tree and branch at:
>>>>     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y
>>>> and the diffstat can be found below.
>>>>
>>>> thanks,
>>>>
>>>> greg k-h
>>>>
>>>> -------------
>>>> Pseudo-Shortlog of commits:
>>>>
>>>> Greg Kroah-Hartman <[email protected]>
>>>>      Linux 4.9.335-rc1
>>>>
>>>> Adrian Hunter <[email protected]>
>>>>      mmc: sdhci: Fix voltage switch delay
>>>
>>>
>>> I am seeing a boot regression on a couple boards and bisect is pointing to the above commit.
>>
>> Same thing here, getting a hard lock for our devices with the SDHCI controller enabled, sometimes we are lucky to see the following:
>>
>> [    4.790367] mmc0: SDHCI controller on 84b0000.sdhci [84b0000.sdhci] using ADMA 64-bit
>> [   25.802351] INFO: rcu_sched detected stalls on CPUs/tasks:
>> [   25.807871]  1-...: (1 GPs behind) idle=561/140000000000000/0 softirq=728/728 fqs=5252
>> [   25.815892]  (detected by 0, t=21017 jiffies, g=61, c=60, q=55)
>> [   25.821834] Task dump for CPU 1:
>> [   25.825069] kworker/1:1     R  running task        0   509      2 0x00000002
>> [   25.832164] Workqueue: events_freezable mmc_rescan
>> [   25.836974] Backtrace:
>> [   25.839440] [<ce32fea4>] (0xce32fea4) from [<ce32fed4>] (0xce32fed4)
>> [   25.845803] Backtrace aborted due to bad frame pointer <cd2f0a54>
>>
>> Also confirmed that reverting that change ("mmc: sdhci: Fix voltage switch delay") allows devices to boot properly.
>>
>> Had not a chance to test the change when submitted for mainline despite being copied, sorry about that.
>>
>> Since that specific commit is also included in the other stable trees (5.4, 5.10, 5.15 and 6.0) I will let you know whether the same issue is present in those trees shortly thereafter.
>
> This only appears to impact 4.9, Adrian is there a missing functional dependency for "mmc: sdhci: Fix voltage switch delay" to work correctly on the 4.9 kernel?

The thing that leaps to mind is that "mmc: sdhci: Fix voltage switch delay" returns out of sdhci_set_ios() without releasing the spinlock which was removed in later kernels. I expect below would help, but a revert might allow a more considered response - it is a holiday here today.


diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index cfd665f0d6db..f3e2aba53ffa 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -1684,7 +1684,7 @@ static void sdhci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
host->timing == ios->timing &&
host->version >= SDHCI_SPEC_300 &&
!sdhci_presetable_values_change(host, ios))
- return;
+ goto out;

ctrl = sdhci_readb(host, SDHCI_HOST_CONTROL);

@@ -1773,7 +1773,7 @@ static void sdhci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
host->ops->set_clock(host, host->clock);
} else
sdhci_writeb(host, ctrl, SDHCI_HOST_CONTROL);
-
+out:
/*
* Some (ENE) controllers go apeshit on some ios operation,
* signalling timeout and CRC errors even on CMD0. Resetting

2022-12-06 11:00:19

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH 4.9 00/62] 4.9.335-rc1 review

Hi!

> This is the start of the stable review cycle for the 4.9.335 release.
> There are 62 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.

CIP testing did not find any problems here:

https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.9.y
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y

Tested-by: Pavel Machek (CIP) <[email protected]>

Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


Attachments:
(No filename) (825.00 B)
signature.asc (201.00 B)
Download all attachments

2022-12-06 11:58:15

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 4.9 00/62] 4.9.335-rc1 review

On Tue, Dec 06, 2022 at 11:23:15AM +0200, Adrian Hunter wrote:
> On 6/12/22 02:11, Florian Fainelli wrote:
> > On 12/5/22 14:48, Florian Fainelli wrote:
> >> On 12/5/22 14:28, Jon Hunter wrote:
> >>> Hi Greg,
> >>>
> >>> On 05/12/2022 19:08, Greg Kroah-Hartman wrote:
> >>>> This is the start of the stable review cycle for the 4.9.335 release.
> >>>> There are 62 patches in this series, all will be posted as a response
> >>>> to this one.? If anyone has any issues with these being applied, please
> >>>> let me know.
> >>>>
> >>>> Responses should be made by Wed, 07 Dec 2022 19:07:46 +0000.
> >>>> Anything received after that time might be too late.
> >>>>
> >>>> The whole patch series can be found in one patch at:
> >>>> ????https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.335-rc1.gz
> >>>> or in the git tree and branch at:
> >>>> ????git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y
> >>>> and the diffstat can be found below.
> >>>>
> >>>> thanks,
> >>>>
> >>>> greg k-h
> >>>>
> >>>> -------------
> >>>> Pseudo-Shortlog of commits:
> >>>>
> >>>> Greg Kroah-Hartman <[email protected]>
> >>>> ???? Linux 4.9.335-rc1
> >>>>
> >>>> Adrian Hunter <[email protected]>
> >>>> ???? mmc: sdhci: Fix voltage switch delay
> >>>
> >>>
> >>> I am seeing a boot regression on a couple boards and bisect is pointing to the above commit.
> >>
> >> Same thing here, getting a hard lock for our devices with the SDHCI controller enabled, sometimes we are lucky to see the following:
> >>
> >> [??? 4.790367] mmc0: SDHCI controller on 84b0000.sdhci [84b0000.sdhci] using ADMA 64-bit
> >> [?? 25.802351] INFO: rcu_sched detected stalls on CPUs/tasks:
> >> [?? 25.807871]? 1-...: (1 GPs behind) idle=561/140000000000000/0 softirq=728/728 fqs=5252
> >> [?? 25.815892]? (detected by 0, t=21017 jiffies, g=61, c=60, q=55)
> >> [?? 25.821834] Task dump for CPU 1:
> >> [?? 25.825069] kworker/1:1???? R? running task??????? 0?? 509????? 2 0x00000002
> >> [?? 25.832164] Workqueue: events_freezable mmc_rescan
> >> [?? 25.836974] Backtrace:
> >> [?? 25.839440] [<ce32fea4>] (0xce32fea4) from [<ce32fed4>] (0xce32fed4)
> >> [?? 25.845803] Backtrace aborted due to bad frame pointer <cd2f0a54>
> >>
> >> Also confirmed that reverting that change ("mmc: sdhci: Fix voltage switch delay") allows devices to boot properly.
> >>
> >> Had not a chance to test the change when submitted for mainline despite being copied, sorry about that.
> >>
> >> Since that specific commit is also included in the other stable trees (5.4, 5.10, 5.15 and 6.0) I will let you know whether the same issue is present in those trees shortly thereafter.
> >
> > This only appears to impact 4.9, Adrian is there a missing functional dependency for "mmc: sdhci: Fix voltage switch delay" to work correctly on the 4.9 kernel?
>
> The thing that leaps to mind is that "mmc: sdhci: Fix voltage switch delay" returns out of sdhci_set_ios() without releasing the spinlock which was removed in later kernels. I expect below would help, but a revert might allow a more considered response - it is a holiday here today.

I'll just drop them for now from 4.9, thanks!

greg k-h