2023-12-27 12:34:11

by Elad Nachman

Subject: [PATCH 2/4] dt-bindings: mmc: add Marvell ac5

From: Elad Nachman <[email protected]>

Add dt bindings for Marvell ac5 eMMC controller

Signed-off-by: Elad Nachman <[email protected]>
---
Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml b/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
index 3a8e74894ae0..50c6de8bf0bc 100644
--- a/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
@@ -34,6 +34,9 @@ properties:
- const: marvell,armada-3700-sdhci
- const: marvell,sdhci-xenon

+ - items:
+ - const: marvell,ac5-sdhci
+ - const: marvell,armada-ap806-sdhci
reg:
minItems: 1
maxItems: 2
--
2.25.1

2023-12-27 12:39:08

by Krzysztof Kozlowski

Subject: Re: [PATCH 2/4] dt-bindings: mmc: add Marvell ac5

On 27/12/2023 13:32, Elad Nachman wrote:
> From: Elad Nachman <[email protected]>
>
> Add dt bindings for Marvell ac5 eMMC controller
>
> Signed-off-by: Elad Nachman <[email protected]>
> ---
> Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml b/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
> index 3a8e74894ae0..50c6de8bf0bc 100644
> --- a/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
> @@ -34,6 +34,9 @@ properties:
> - const: marvell,armada-3700-sdhci
> - const: marvell,sdhci-xenon
>
> + - items:
> + - const: marvell,ac5-sdhci

Please make earlier const as enum and add it there.

> + - const: marvell,armada-ap806-sdhci

You also missed here blank line, but that won't matter after above change.


Best regards,
Krzysztof

2023-12-27 12:42:15

by Krzysztof Kozlowski

Subject: Re: [PATCH 2/4] dt-bindings: mmc: add Marvell ac5

On 27/12/2023 13:32, Elad Nachman wrote:
> From: Elad Nachman <[email protected]>
>
> Add dt bindings for Marvell ac5 eMMC controller

Driver change says it is not fully compatible. Your commit msg here
explains nothing, except what subject is saying. You have entire commit
msg to explain such cases.


Best regards,
Krzysztof