2005-12-13 17:05:10

by Ben Gardner

[permalink] [raw]
Subject: [PATCH] i386: GPIO driver for AMD CS5535/CS5536

A simple driver for the CS5535 and CS5536 that allows a user-space
program to manipulate GPIO pins.
The CS5535/CS5536 chips are Geode processor companion devices.

Signed-off-by: Ben Gardner <[email protected]>
---
Andrew,

This patch assumes that my previous cs5535-gpio patch has been
deleted, which I see you have already done.
I dropped the cs5535-cpu patch because the root cause looks like a BIOS bug.
I will work the SMBus driver with Jean on the lm-sensors mailing list.

Thanks,
Ben


Attachments:
(No filename) (494.00 B)
cs5535-gpio.patch.txt (7.55 kB)
Download all attachments

2005-12-13 22:24:28

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH] i386: GPIO driver for AMD CS5535/CS5536

Ben Gardner <[email protected]> wrote:
>
> A simple driver for the CS5535 and CS5536 that allows a user-space
> program to manipulate GPIO pins.
> The CS5535/CS5536 chips are Geode processor companion devices.

Should CONFIG_CS5535_GPIO depend on X86 or X86_32?

2005-12-13 22:57:53

by Ben Gardner

[permalink] [raw]
Subject: Re: [PATCH] i386: GPIO driver for AMD CS5535/CS5536

On 12/13/05, Andrew Morton <[email protected]> wrote:
> Ben Gardner <[email protected]> wrote:
> >
> > A simple driver for the CS5535 and CS5536 that allows a user-space
> > program to manipulate GPIO pins.
> > The CS5535/CS5536 chips are Geode processor companion devices.
>
> Should CONFIG_CS5535_GPIO depend on X86 or X86_32?
>

I think it should depend on X86_32.
Would you like me to send you a -fix patch or would you rather take care of it?

Thanks,
Ben

2005-12-13 23:08:55

by Jordan Crouse

[permalink] [raw]
Subject: Re: [PATCH] i386: GPIO driver for AMD CS5535/CS5536

> A simple driver for the CS5535 and CS5536 that allows a user-space
> program to manipulate GPIO pins.
> The CS5535/CS5536 chips are Geode processor companion devices.

> Signed-off-by: Ben Gardner <bgardner <at> wabtec.com>

This all looks excellent to me. Just FYI - If you want to get rid of the
rdmsr and just use the PCI header, you can also get the IO base of the
GPIO registers from BAR1 of the DIVIL device. Not a big deal,
but some people like to stay away from MSR accesses if they can avoid it.

Thanks for your hard work - its good to see Geode users pop up in the
community! :)

Jordan
--
Jordan Crouse
Senior Linux Engineer
AMD - Personal Connectivity Solutions Group
<http://www.amd.com/embeddedprocessors>

2005-12-13 23:27:59

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH] i386: GPIO driver for AMD CS5535/CS5536

Ben Gardner <[email protected]> wrote:
>
> On 12/13/05, Andrew Morton <[email protected]> wrote:
> > Ben Gardner <[email protected]> wrote:
> > >
> > > A simple driver for the CS5535 and CS5536 that allows a user-space
> > > program to manipulate GPIO pins.
> > > The CS5535/CS5536 chips are Geode processor companion devices.
> >
> > Should CONFIG_CS5535_GPIO depend on X86 or X86_32?
> >
>
> I think it should depend on X86_32.

OK.

> Would you like me to send you a -fix patch or would you rather take care of it?

I fixed it up.