Commit 9f794056db5b ("platform/surface: Add KIP/POS tablet-mode switch
driver") adds the section MICROSOFT SURFACE AGGREGATOR TABLET-MODE SWITCH
with a file entry, but the file that is added with this commit is actually
named slightly differently.
file entry name: drivers/platform/surface/surface_aggregator_tablet_switch.c
added file name: drivers/platform/surface/surface_aggregator_tabletsw.c
Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
broken reference.
Repair this file entry to the actual file name added with the commit above.
Signed-off-by: Lukas Bulwahn <[email protected]>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9bfd69e2b83d..9ec738419526 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -13440,7 +13440,7 @@ MICROSOFT SURFACE AGGREGATOR TABLET-MODE SWITCH
M: Maximilian Luz <[email protected]>
L: [email protected]
S: Maintained
-F: drivers/platform/surface/surface_aggregator_tablet_switch.c
+F: drivers/platform/surface/surface_aggregator_tabletsw.c
MICROSOFT SURFACE BATTERY AND AC DRIVERS
M: Maximilian Luz <[email protected]>
--
2.17.1
On Wed, Jul 13, 2022 at 6:19 AM Lukas Bulwahn <[email protected]> wrote:
>
> Commit 9f794056db5b ("platform/surface: Add KIP/POS tablet-mode switch
> driver") adds the section MICROSOFT SURFACE AGGREGATOR TABLET-MODE SWITCH
> with a file entry, but the file that is added with this commit is actually
> named slightly differently.
>
> file entry name: drivers/platform/surface/surface_aggregator_tablet_switch.c
> added file name: drivers/platform/surface/surface_aggregator_tabletsw.c
>
> Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
> broken reference.
>
> Repair this file entry to the actual file name added with the commit above.
Fixes tag?
Reviewed-by: Andy Shevchenko <[email protected]>
With Best Regards,
Andy Shevchenko
On 7/13/22 06:09, Lukas Bulwahn wrote:
> Commit 9f794056db5b ("platform/surface: Add KIP/POS tablet-mode switch
> driver") adds the section MICROSOFT SURFACE AGGREGATOR TABLET-MODE SWITCH
> with a file entry, but the file that is added with this commit is actually
> named slightly differently.
>
> file entry name: drivers/platform/surface/surface_aggregator_tablet_switch.c
> added file name: drivers/platform/surface/surface_aggregator_tabletsw.c
>
> Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
> broken reference.
>
> Repair this file entry to the actual file name added with the commit above.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
Thanks for fixing this and sorry for messing this up, I should have noticed.
With the appropriate Fixes tag, as mentioned by Andy:
Reviewed-by: Maximilian Luz <[email protected]>
> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9bfd69e2b83d..9ec738419526 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -13440,7 +13440,7 @@ MICROSOFT SURFACE AGGREGATOR TABLET-MODE SWITCH
> M: Maximilian Luz <[email protected]>
> L: [email protected]
> S: Maintained
> -F: drivers/platform/surface/surface_aggregator_tablet_switch.c
> +F: drivers/platform/surface/surface_aggregator_tabletsw.c
>
> MICROSOFT SURFACE BATTERY AND AC DRIVERS
> M: Maximilian Luz <[email protected]>
Hi,
On 7/13/22 06:09, Lukas Bulwahn wrote:
> Commit 9f794056db5b ("platform/surface: Add KIP/POS tablet-mode switch
> driver") adds the section MICROSOFT SURFACE AGGREGATOR TABLET-MODE SWITCH
> with a file entry, but the file that is added with this commit is actually
> named slightly differently.
>
> file entry name: drivers/platform/surface/surface_aggregator_tablet_switch.c
> added file name: drivers/platform/surface/surface_aggregator_tabletsw.c
>
> Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
> broken reference.
>
> Repair this file entry to the actual file name added with the commit above.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
With the requested Fixes tag added.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9bfd69e2b83d..9ec738419526 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -13440,7 +13440,7 @@ MICROSOFT SURFACE AGGREGATOR TABLET-MODE SWITCH
> M: Maximilian Luz <[email protected]>
> L: [email protected]
> S: Maintained
> -F: drivers/platform/surface/surface_aggregator_tablet_switch.c
> +F: drivers/platform/surface/surface_aggregator_tabletsw.c
>
> MICROSOFT SURFACE BATTERY AND AC DRIVERS
> M: Maximilian Luz <[email protected]>