2021-04-01 18:08:27

by Beatriz Martins de Carvalho

Subject: [PATCH 2/2] staging: media: omap4iss: align arguments with open parenthesis

Cleans up checks of "Alignment should match open parenthesis"
in iss.c:96.

Signed-off-by: Beatriz Martins de Carvalho <[email protected]>
---
drivers/staging/media/omap4iss/iss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
index e8f724dbf810..472f1837632e 100644
--- a/drivers/staging/media/omap4iss/iss.c
+++ b/drivers/staging/media/omap4iss/iss.c
@@ -963,7 +963,7 @@ iss_register_subdev_group(struct iss_device *iss,
}

subdev = v4l2_i2c_new_subdev_board(&iss->v4l2_dev, adapter,
- board_info->board_info, NULL);
+ board_info->board_info, NULL);
if (!subdev) {
dev_err(iss->dev, "Unable to register subdev %s\n",
board_info->board_info->type);
--
2.25.1

2021-04-01 18:33:00

by Matthew Wilcox

Subject: Re: [Outreachy kernel] [PATCH 2/2] staging: media: omap4iss: align arguments with open parenthesis

On Thu, Apr 01, 2021 at 04:07:39PM +0100, Beatriz Martins de Carvalho wrote:
> subdev = v4l2_i2c_new_subdev_board(&iss->v4l2_dev, adapter,
> - board_info->board_info, NULL);
> + board_info->board_info, NULL);

Also not a readability improvement. This checkpatch warning should
be disregarded.

2021-04-07 21:16:19

by Hans Verkuil

Subject: Re: [PATCH 2/2] staging: media: omap4iss: align arguments with open parenthesis

Hi Beatriz,

On 01/04/2021 17:07, Beatriz Martins de Carvalho wrote:
> Cleans up checks of "Alignment should match open parenthesis"
> in iss.c:96.

Looks good. I'll take this patch.

You can use this reference to record your contribution:

https://patchwork.linuxtv.org/project/linux-media/patch/475dbbe5774cbfed2d924807d8a3cfeb84b3d845.1617287509.git.martinsdecarvalhobeatriz@gmail.com/

The state will change to Accepted once it is merged in our media tree
here: https://git.linuxtv.org/media_tree.git/log/

Regards,

Hans

>
> Signed-off-by: Beatriz Martins de Carvalho <[email protected]>
> ---
> drivers/staging/media/omap4iss/iss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
> index e8f724dbf810..472f1837632e 100644
> --- a/drivers/staging/media/omap4iss/iss.c
> +++ b/drivers/staging/media/omap4iss/iss.c
> @@ -963,7 +963,7 @@ iss_register_subdev_group(struct iss_device *iss,
> }
>
> subdev = v4l2_i2c_new_subdev_board(&iss->v4l2_dev, adapter,
> - board_info->board_info, NULL);
> + board_info->board_info, NULL);
> if (!subdev) {
> dev_err(iss->dev, "Unable to register subdev %s\n",
> board_info->board_info->type);
>