2021-10-04 18:09:23

by Borislav Petkov

[permalink] [raw]
Subject: Re: [Bug 214453] New: skl_int3472_unregister_clock: kernel NULL pointer dereference (HP Elite x2 1013 G3)

Adding more people to Cc.

On Fri, Sep 17, 2021 at 12:18:27PM +0000, [email protected] wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=214453
>
> Bug ID: 214453
> Summary: skl_int3472_unregister_clock: kernel NULL pointer
> dereference (HP Elite x2 1013 G3)
> Product: Platform Specific/Hardware
> Version: 2.5
> Kernel Version: 5.14.5
> Hardware: Intel
> OS: Linux
> Tree: Mainline
> Status: NEW
> Severity: low
> Priority: P1
> Component: x86-64
> Assignee: [email protected]
> Reporter: [email protected]
> Regression: No
>
> Created attachment 298863
> --> https://bugzilla.kernel.org/attachment.cgi?id=298863&action=edit
> dmesg oops log
>
> On a HP Elite x2 1013 G3 a kernel oops is caused by int3472:
>
> [ 8.820565] int3472-discrete INT3472:02: No sensor module config
> [ 8.820569] int3472-discrete INT3472:02: error -EINVAL: Failed to map
> regulator to sensor
> [ 8.820574] BUG: kernel NULL pointer dereference, address: 0000000000000000
> [...]
> [ 8.820654] Call Trace:
> [ 8.820657] clkdev_drop+0x1d/0x60
> [ 8.820665] skl_int3472_unregister_clock+0x15/0x30 [intel_skl_int3472
> a61329898df9463f8661b1eee1ed1e20b1626f62]
>
> --
> You may reply to this email to add a comment.
>
> You are receiving this mail because:
> You are watching the assignee of the bug.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette


2021-10-05 14:47:32

by Daniel Scally

[permalink] [raw]
Subject: Re: [Bug 214453] New: skl_int3472_unregister_clock: kernel NULL pointer dereference (HP Elite x2 1013 G3)

Hi Borislav

On 04/10/2021 17:59, Borislav Petkov wrote:
> Adding more people to Cc.
>
> On Fri, Sep 17, 2021 at 12:18:27PM +0000, [email protected] wrote:
>> https://bugzilla.kernel.org/show_bug.cgi?id=214453
>>
>> Bug ID: 214453
>> Summary: skl_int3472_unregister_clock: kernel NULL pointer
>> dereference (HP Elite x2 1013 G3)
>> Product: Platform Specific/Hardware
>> Version: 2.5
>> Kernel Version: 5.14.5
>> Hardware: Intel
>> OS: Linux
>> Tree: Mainline
>> Status: NEW
>> Severity: low
>> Priority: P1
>> Component: x86-64
>> Assignee: [email protected]
>> Reporter: [email protected]
>> Regression: No
>>
>> Created attachment 298863
>> --> https://bugzilla.kernel.org/attachment.cgi?id=298863&action=edit
>> dmesg oops log
>>
>> On a HP Elite x2 1013 G3 a kernel oops is caused by int3472:
>>
>> [ 8.820565] int3472-discrete INT3472:02: No sensor module config
>> [ 8.820569] int3472-discrete INT3472:02: error -EINVAL: Failed to map
>> regulator to sensor
>> [ 8.820574] BUG: kernel NULL pointer dereference, address: 0000000000000000
>> [...]
>> [ 8.820654] Call Trace:
>> [ 8.820657] clkdev_drop+0x1d/0x60
>> [ 8.820665] skl_int3472_unregister_clock+0x15/0x30 [intel_skl_int3472
>> a61329898df9463f8661b1eee1ed1e20b1626f62]


Thanks for the report; let me take a look and see if I can spot what's
going wrong.


>> --
>> You may reply to this email to add a comment.
>>
>> You are receiving this mail because:
>> You are watching the assignee of the bug.

2021-10-08 22:20:08

by Daniel Scally

[permalink] [raw]
Subject: Re: [Bug 214453] New: skl_int3472_unregister_clock: kernel NULL pointer dereference (HP Elite x2 1013 G3)

Hello

On 04/10/2021 17:59, Borislav Petkov wrote:
> Adding more people to Cc.
>
> On Fri, Sep 17, 2021 at 12:18:27PM +0000, [email protected] wrote:
>> https://bugzilla.kernel.org/show_bug.cgi?id=214453
>>
>> Bug ID: 214453
>> Summary: skl_int3472_unregister_clock: kernel NULL pointer
>> dereference (HP Elite x2 1013 G3)
>> Product: Platform Specific/Hardware
>> Version: 2.5
>> Kernel Version: 5.14.5
>> Hardware: Intel
>> OS: Linux
>> Tree: Mainline
>> Status: NEW
>> Severity: low
>> Priority: P1
>> Component: x86-64
>> Assignee: [email protected]
>> Reporter: [email protected]
>> Regression: No
>>
>> Created attachment 298863
>> --> https://bugzilla.kernel.org/attachment.cgi?id=298863&action=edit
>> dmesg oops log
>>
>> On a HP Elite x2 1013 G3 a kernel oops is caused by int3472:
>>
>> [ 8.820565] int3472-discrete INT3472:02: No sensor module config
>> [ 8.820569] int3472-discrete INT3472:02: error -EINVAL: Failed to map
>> regulator to sensor
>> [ 8.820574] BUG: kernel NULL pointer dereference, address: 0000000000000000
>> [...]
>> [ 8.820654] Call Trace:
>> [ 8.820657] clkdev_drop+0x1d/0x60
>> [ 8.820665] skl_int3472_unregister_clock+0x15/0x30 [intel_skl_int3472
>> a61329898df9463f8661b1eee1ed1e20b1626f62]


I can patch this - but do I need to do to show that the patch is for
that specific bug report or anything?

>> --
>> You may reply to this email to add a comment.
>>
>> You are receiving this mail because:
>> You are watching the assignee of the bug.

2021-10-09 08:16:47

by Borislav Petkov

[permalink] [raw]
Subject: Re: [Bug 214453] New: skl_int3472_unregister_clock: kernel NULL pointer dereference (HP Elite x2 1013 G3)

On Fri, Oct 08, 2021 at 11:18:50PM +0100, Daniel Scally wrote:
> I can patch this - but do I need to do to show that the patch is for
> that specific bug report or anything?

What we do in such cases, usually, is add

Link: https://bugzilla.kernel.org/show_bug.cgi?id=214453

to the commit message, under the SOB chain.

Also, you probably also should give in a Fixes: tag the commit ID of the
patch your fix is for, so that your fix gets automatically backported to
stable.

I.e.:

Fixes: 12-char-sha1-abbrev ("Commit title")
Cc: <[email protected]>

HTH.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette