2022-12-05 19:15:54

by Rafael J. Wysocki

[permalink] [raw]
Subject: [PATCH v1 3/5] ACPI: processor: perflib: Rearrange unregistration routine

From: Rafael J. Wysocki <[email protected]>

Rearrange acpi_processor_unregister_performance() to follow a more
common error handling pattern and drop a redundant "return" statement
from the end of it.

No expected functional impact.

Signed-off-by: Rafael J. Wysocki <[email protected]>
---
drivers/acpi/processor_perflib.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)

Index: linux-pm/drivers/acpi/processor_perflib.c
===================================================================
--- linux-pm.orig/drivers/acpi/processor_perflib.c
+++ linux-pm/drivers/acpi/processor_perflib.c
@@ -754,18 +754,15 @@ void acpi_processor_unregister_performan
mutex_lock(&performance_mutex);

pr = per_cpu(processors, cpu);
- if (!pr) {
- mutex_unlock(&performance_mutex);
- return;
- }
+ if (!pr)
+ goto unlock;

if (pr->performance)
kfree(pr->performance->states);

pr->performance = NULL;

+unlock:
mutex_unlock(&performance_mutex);
-
- return;
}
EXPORT_SYMBOL(acpi_processor_unregister_performance);