Jeff Garzik <[email protected]> wrote:
> Eric Brower wrote:
> > Attached is a patch to 2.4's ethtool.h to use appropriate,
> > userspace-accessible data types (__u8 and friends, rather than u8 and
> > friends).
>
> I'm happy with u8/u16/u32, so it stays that way :)
I'm not arguing about a personal, stylistic preference-- these differing types
have been provided for a reason and the ethtool header file should comply with
the stated and idiomatic usage within the kernel sources, as do other such
header files.
Without such a change, userspace applications cannot use the ethtool ioctl
interface without completely unnecessary gyrations. I truly appreciate your
preference, but this has nothing to do with style.
E