2024-02-13 07:47:10

by Aaron Parfitt

Subject: [PATCH] Staging: rtl8192e: rtl819x_HTProc: Removed braces from single statement block

Fixed code style issue

Signed-off-by: Aaron Parfitt <[email protected]>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 6d0912f90198..49b882c363bf 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -480,9 +480,9 @@ void ht_on_assoc_rsp(struct rtllib_device *ieee)
}

ht_info->current_mpdu_density = pPeerHTCap->MPDUDensity;
- if (ht_info->iot_action & HT_IOT_ACT_TX_USE_AMSDU_8K) {
+ if (ht_info->iot_action & HT_IOT_ACT_TX_USE_AMSDU_8K)
ht_info->current_ampdu_enable = false;
- }
+
ht_info->cur_rx_reorder_enable = 1;

if (pPeerHTCap->MCS[0] == 0)
--
2.43.0

2024-02-15 09:33:55

by Philipp Hortmann

Subject: Re: [PATCH] Staging: rtl8192e: rtl819x_HTProc: Removed braces from single statement block

Hi Aaron,

looks OK but can we make the subject more unique. Maybe like this:

[PATCH] Staging: rtl8192e: Removed braces from single statement block in
ht_on_assoc_rsp

Or is this getting to long?

I propose the description to be like:

Remove braces from single statement blocks to clear checkpatch warning.

If you change this you need to make a v2 with changelog.

Bye Philipp

On 13.02.24 08:46, Aaron Parfitt wrote:
> Fixed code style issue
>
> Signed-off-by: Aaron Parfitt <[email protected]>
> ---
> drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> index 6d0912f90198..49b882c363bf 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> @@ -480,9 +480,9 @@ void ht_on_assoc_rsp(struct rtllib_device *ieee)
> }
>
> ht_info->current_mpdu_density = pPeerHTCap->MPDUDensity;
> - if (ht_info->iot_action & HT_IOT_ACT_TX_USE_AMSDU_8K) {
> + if (ht_info->iot_action & HT_IOT_ACT_TX_USE_AMSDU_8K)
> ht_info->current_ampdu_enable = false;
> - }
> +
> ht_info->cur_rx_reorder_enable = 1;
>
> if (pPeerHTCap->MCS[0] == 0)