2023-11-28 14:40:10

by Dan Carpenter

Subject: [PATCH] media: chips-media: wave5: remove duplicate check

We already verified that "ret" is zero a few lines earlier. Delete this
duplicate check.

Signed-off-by: Dan Carpenter <[email protected]>
---
drivers/media/platform/chips-media/wave5/wave5-hw.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/media/platform/chips-media/wave5/wave5-hw.c b/drivers/media/platform/chips-media/wave5/wave5-hw.c
index 3fcb2d92add8..f1e022fb148e 100644
--- a/drivers/media/platform/chips-media/wave5/wave5-hw.c
+++ b/drivers/media/platform/chips-media/wave5/wave5-hw.c
@@ -578,9 +578,6 @@ int wave5_vpu_dec_init_seq(struct vpu_instance *inst)
dev_dbg(inst->dev->dev, "%s: init seq sent (queue %u : %u)\n", __func__,
p_dec_info->instance_queue_count, p_dec_info->report_queue_count);

- if (ret)
- return ret;
-
return 0;
}

--
2.42.0

2023-12-07 19:08:43

by Nicolas Dufresne

Subject: Re: [PATCH] media: chips-media: wave5: remove duplicate check

Le mardi 28 novembre 2023 à 17:39 +0300, Dan Carpenter a écrit :
> We already verified that "ret" is zero a few lines earlier. Delete this
> duplicate check.
>
> Signed-off-by: Dan Carpenter <[email protected]>

Reviewed-by: Nicolas Dufresne <[email protected]>

> ---
> drivers/media/platform/chips-media/wave5/wave5-hw.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/media/platform/chips-media/wave5/wave5-hw.c b/drivers/media/platform/chips-media/wave5/wave5-hw.c
> index 3fcb2d92add8..f1e022fb148e 100644
> --- a/drivers/media/platform/chips-media/wave5/wave5-hw.c
> +++ b/drivers/media/platform/chips-media/wave5/wave5-hw.c
> @@ -578,9 +578,6 @@ int wave5_vpu_dec_init_seq(struct vpu_instance *inst)
> dev_dbg(inst->dev->dev, "%s: init seq sent (queue %u : %u)\n", __func__,
> p_dec_info->instance_queue_count, p_dec_info->report_queue_count);
>
> - if (ret)
> - return ret;
> -
> return 0;
> }
>