2023-07-28 01:34:19

by Randy Dunlap

Subject: [PATCH v2] x86/APM: drop the duplicate APM_MINOR_DEV macro

This source file already includes <linux/miscdevice.h>, which contains
the same macro. It doesn't need to be defined here again.

Fixes: 874bcd00f520 ("apm-emulation: move APM_MINOR_DEV to include/linux/miscdevice.h")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Jiri Kosina <[email protected]>
Cc: [email protected]
Cc: Sohil Mehta <[email protected]>
Cc: Corentin Labbe <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
---
v2: change the Fixes: tag (Sohil)

arch/x86/kernel/apm_32.c | 6 ------
1 file changed, 6 deletions(-)

diff -- a/arch/x86/kernel/apm_32.c b/arch/x86/kernel/apm_32.c
--- a/arch/x86/kernel/apm_32.c
+++ b/arch/x86/kernel/apm_32.c
@@ -239,12 +239,6 @@ extern int (*console_blank_hook)(int);
#endif

/*
- * The apm_bios device is one of the misc char devices.
- * This is its minor number.
- */
-#define APM_MINOR_DEV 134
-
-/*
* Various options can be changed at boot time as follows:
* (We allow underscores for compatibility with the modules code)
* apm=on/off enable/disable APM

2023-07-28 17:35:25

by Sohil Mehta

Subject: Re: [PATCH v2] x86/APM: drop the duplicate APM_MINOR_DEV macro

Just a nit, the tip tree handbook says:

> "The condensed patch description in the subject line should start with
> a uppercase letter and ..."

https://docs.kernel.org/process/maintainer-tip.html?highlight=tip+maintainer#patch-subject

On 7/27/2023 6:11 PM, Randy Dunlap wrote:
> This source file already includes <linux/miscdevice.h>, which contains
> the same macro. It doesn't need to be defined here again.
>
> Fixes: 874bcd00f520 ("apm-emulation: move APM_MINOR_DEV to include/linux/miscdevice.h")
> Signed-off-by: Randy Dunlap <[email protected]>

Reviewed-by: Sohil Mehta <[email protected]>