On 09/06/21 7:36 pm, Vignesh Raghavendra wrote:
> Last 256K of OCRAM (256K@0x701c0000) is reserved for SYSFW usage. Hence
> add an entry in DT so that its not used for generic pool memory
> allocation.
>
> Without this certain drivers using SRAM as generic shared memory pool
> may end up being allocated memory from this range and will lead to boot
> time crash when the reserved range is accessed (due to firewall
> violation).
>
> Signed-off-by: Vignesh Raghavendra <[email protected]>
You might want to re-base on top of Aswath's patch updating ATF address. Otherwise:
Reviewed-by: Lokesh Vutla <[email protected]>
Thanks and regards,
Lokesh
On 6/9/21 8:56 PM, Lokesh Vutla wrote:
>
>
> On 09/06/21 7:36 pm, Vignesh Raghavendra wrote:
>> Last 256K of OCRAM (256K@0x701c0000) is reserved for SYSFW usage. Hence
>> add an entry in DT so that its not used for generic pool memory
>> allocation.
>>
>> Without this certain drivers using SRAM as generic shared memory pool
>> may end up being allocated memory from this range and will lead to boot
>> time crash when the reserved range is accessed (due to firewall
>> violation).
>>
>> Signed-off-by: Vignesh Raghavendra <[email protected]>
>
> You might want to re-base on top of Aswath's patch updating ATF address. Otherwise:
>
> Reviewed-by: Lokesh Vutla <[email protected]>
>
Actually, this patch should go in before Aswath's patch as moving ATF
location around exposed issue of drivers getting memory allocations
overlapping SYSFW reserved ranges
Regards
Vignesh
On 23:59-20210611, Vignesh Raghavendra wrote:
>
>
> On 6/9/21 8:56 PM, Lokesh Vutla wrote:
> >
> >
> > On 09/06/21 7:36 pm, Vignesh Raghavendra wrote:
> >> Last 256K of OCRAM (256K@0x701c0000) is reserved for SYSFW usage. Hence
> >> add an entry in DT so that its not used for generic pool memory
> >> allocation.
> >>
> >> Without this certain drivers using SRAM as generic shared memory pool
> >> may end up being allocated memory from this range and will lead to boot
> >> time crash when the reserved range is accessed (due to firewall
> >> violation).
> >>
> >> Signed-off-by: Vignesh Raghavendra <[email protected]>
> >
> > You might want to re-base on top of Aswath's patch updating ATF address. Otherwise:
> >
> > Reviewed-by: Lokesh Vutla <[email protected]>
> >
>
> Actually, this patch should go in before Aswath's patch as moving ATF
> location around exposed issue of drivers getting memory allocations
> overlapping SYSFW reserved ranges
I have applied Aswath's patch, please rebase. understood this is a bug,
but either way, it really was'nt a regression of stuff that was present.
please fix and send asap so that I can pick it up.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D