2024-04-17 10:15:21

by Lukas Bulwahn

[permalink] [raw]
Subject: [PATCH] MAINTAINERS: repair file entry in DOCUMENTATION

From: Lukas Bulwahn <[email protected]>

Commit 1e596d5eff3d ("docs: Detect variable fonts and suggest denylisting
them") adds the new script check-variable-fonts.sh and intends to refer to
it in the DOCUMENTATION section in MAINTAINERS. However, the file entry
refers to scripts/check-variable-font.sh. Note the missing "s".

Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
broken reference.

Repair this new file entry in the DOCUMENTATION section.

Signed-off-by: Lukas Bulwahn <[email protected]>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 4356b28ce625..250c8f8caa08 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6493,7 +6493,7 @@ S: Maintained
P: Documentation/doc-guide/maintainer-profile.rst
T: git git://git.lwn.net/linux.git docs-next
F: Documentation/
-F: scripts/check-variable-font.sh
+F: scripts/check-variable-fonts.sh
F: scripts/documentation-file-ref-check
F: scripts/kernel-doc
F: scripts/sphinx-pre-install
--
2.44.0



2024-04-17 13:47:23

by Akira Yokosawa

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: repair file entry in DOCUMENTATION

On Wed, 17 Apr 2024 12:14:29 +0200, Lukas Bulwahn wrote:
> From: Lukas Bulwahn <[email protected]>
>
> Commit 1e596d5eff3d ("docs: Detect variable fonts and suggest denylisting
> them") adds the new script check-variable-fonts.sh and intends to refer to
> it in the DOCUMENTATION section in MAINTAINERS. However, the file entry
> refers to scripts/check-variable-font.sh. Note the missing "s".

My bad... :-/

>
> Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
> broken reference.
>
> Repair this new file entry in the DOCUMENTATION section.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>

Thank you for the fix!

Reviewed-by: Akira Yokosawa <[email protected]>

> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4356b28ce625..250c8f8caa08 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6493,7 +6493,7 @@ S: Maintained
> P: Documentation/doc-guide/maintainer-profile.rst
> T: git git://git.lwn.net/linux.git docs-next
> F: Documentation/
> -F: scripts/check-variable-font.sh
> +F: scripts/check-variable-fonts.sh
> F: scripts/documentation-file-ref-check
> F: scripts/kernel-doc
> F: scripts/sphinx-pre-install


2024-04-24 19:43:36

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: repair file entry in DOCUMENTATION

Lukas Bulwahn <[email protected]> writes:

> From: Lukas Bulwahn <[email protected]>
>
> Commit 1e596d5eff3d ("docs: Detect variable fonts and suggest denylisting
> them") adds the new script check-variable-fonts.sh and intends to refer to
> it in the DOCUMENTATION section in MAINTAINERS. However, the file entry
> refers to scripts/check-variable-font.sh. Note the missing "s".
>
> Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
> broken reference.
>
> Repair this new file entry in the DOCUMENTATION section.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4356b28ce625..250c8f8caa08 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6493,7 +6493,7 @@ S: Maintained
> P: Documentation/doc-guide/maintainer-profile.rst
> T: git git://git.lwn.net/linux.git docs-next
> F: Documentation/
> -F: scripts/check-variable-font.sh
> +F: scripts/check-variable-fonts.sh
> F: scripts/documentation-file-ref-check

Applied, thanks.

jon