2018-01-12 00:49:10

by Steven Rostedt

Subject: [PATCH 09/10] lib traceeevent: Fix missing break in FALSE case of pevent_filter_clear_trivial()

From: Taeung Song <[email protected]>

Currently the FILTER_TRIVIAL_FALSE case has a missing break statement, if
the trivial type is FALSE, it will also run into the TRUE case, and always
be skipped as the TRUE statement will continue the loop on the inverse
condition of the FALSE statement.

Link: http://lkml.kernel.org/r/[email protected]

Reported-by: Namhyung Kim <[email protected]>
Signed-off-by: Taeung Song <[email protected]>
Signed-off-by: Steven Rostedt (VMware) <[email protected]>
---
tools/lib/traceevent/parse-filter.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c
index 2410afdcbcfe..2b9048f90bae 100644
--- a/tools/lib/traceevent/parse-filter.c
+++ b/tools/lib/traceevent/parse-filter.c
@@ -1631,6 +1631,7 @@ int pevent_filter_clear_trivial(struct event_filter *filter,
case FILTER_TRIVIAL_FALSE:
if (filter_type->filter->boolean.value)
continue;
+ break;
case FILTER_TRIVIAL_TRUE:
if (!filter_type->filter->boolean.value)
continue;
--
2.13.2

2018-01-12 01:00:41

by Taeung Song

Subject: Re: [PATCH 09/10] lib traceeevent: Fix missing break in FALSE case of pevent_filter_clear_trivial()

Hi Steven,

I found a trivial typo "eee" on the commit log title
It seems better to change "lib traceeevent" to " lib traceevent",
if you want to do it..

Thanks,
Taeung

On 01/12/2018 09:47 AM, Steven Rostedt wrote:

2018-01-12 01:14:40

by Steven Rostedt

Subject: Re: [PATCH 09/10] lib traceeevent: Fix missing break in FALSE case of pevent_filter_clear_trivial()

On Fri, 12 Jan 2018 10:00:34 +0900
Taeung Song <[email protected]> wrote:

> Hi Steven,
>
> I found a trivial typo "eee" on the commit log title

That traceevent got too close to a nuclear power plant.

> It seems better to change "lib traceeevent" to " lib traceevent",
> if you want to do it..

Yeah it should be changed. Not sure I want to send a full series for
such an update. I can send an updated patch, another full
series, or Arnaldo could manually fix it.

Arnaldo, your call.

-- Steve

2018-01-12 16:02:21

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH 09/10] lib traceeevent: Fix missing break in FALSE case of pevent_filter_clear_trivial()

Em Thu, Jan 11, 2018 at 08:14:35PM -0500, Steven Rostedt escreveu:
> On Fri, 12 Jan 2018 10:00:34 +0900
> Taeung Song <[email protected]> wrote:
>
> > Hi Steven,
> >
> > I found a trivial typo "eee" on the commit log title
>
> That traceevent got too close to a nuclear power plant.
>
> > It seems better to change "lib traceeevent" to " lib traceevent",
> > if you want to do it..
>
> Yeah it should be changed. Not sure I want to send a full series for
> such an update. I can send an updated patch, another full
> series, or Arnaldo could manually fix it.
>
> Arnaldo, your call.

I'll fix it, thanks.

- Arnaldo