2019-06-23 15:12:15

by Denis Efremov

[permalink] [raw]
Subject: [PATCH] parisc: asm: psw.h: missing header guard

The psw.h header file contains #ifndef directive of the guard,
but the complimentary #define directive is missing. The patch
adds the appropriate #define to fix the header guard.

Signed-off-by: Denis Efremov <[email protected]>
---
arch/parisc/include/asm/psw.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/parisc/include/asm/psw.h b/arch/parisc/include/asm/psw.h
index 76c301146c31..7a175e866ed0 100644
--- a/arch/parisc/include/asm/psw.h
+++ b/arch/parisc/include/asm/psw.h
@@ -1,5 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0 */
#ifndef _PARISC_PSW_H
+#define _PARISC_PSW_H


#define PSW_I 0x00000001
--
2.21.0


2019-06-23 16:13:28

by Rolf Eike Beer

[permalink] [raw]
Subject: Re: [PATCH] parisc: asm: psw.h: missing header guard

Denis Efremov wrote:
> The psw.h header file contains #ifndef directive of the guard,
> but the complimentary #define directive is missing. The patch
> adds the appropriate #define to fix the header guard.
>
> Signed-off-by: Denis Efremov <[email protected]>
> ---
> arch/parisc/include/asm/psw.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/parisc/include/asm/psw.h b/arch/parisc/include/asm/psw.h
> index 76c301146c31..7a175e866ed0 100644
> --- a/arch/parisc/include/asm/psw.h
> +++ b/arch/parisc/include/asm/psw.h
> @@ -1,5 +1,6 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> #ifndef _PARISC_PSW_H
> +#define _PARISC_PSW_H
>
>
> #define PSW_I 0x00000001

You could have removed one of the 2 empty lines then.

Eike

Attachments:
signature.asc (201.00 B)
This is a digitally signed message part.

2019-06-24 08:55:18

by Denis Efremov

[permalink] [raw]
Subject: Re: [PATCH] parisc: asm: psw.h: missing header guard

Rolf Eike Beer wrote:
>
> You could have removed one of the 2 empty lines then.
>

Will send the v2 in minutes.

Denis

2019-06-24 08:58:27

by Denis Efremov

[permalink] [raw]
Subject: [PATCH v2] parisc: asm: psw.h: missing header guard

The psw.h header file contains #ifndef directive of the guard,
but the complimentary #define directive is missing. The patch
adds the appropriate #define to fix the header guard.

Signed-off-by: Denis Efremov <[email protected]>
---
arch/parisc/include/asm/psw.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/parisc/include/asm/psw.h b/arch/parisc/include/asm/psw.h
index 76c301146c31..46921ffcc407 100644
--- a/arch/parisc/include/asm/psw.h
+++ b/arch/parisc/include/asm/psw.h
@@ -1,6 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0 */
#ifndef _PARISC_PSW_H
-
+#define _PARISC_PSW_H

#define PSW_I 0x00000001
#define PSW_D 0x00000002
--
2.21.0