2024-03-04 16:07:33

by David Lechner

Subject: [PATCH v2 1/3] spi: axi-spi-engine: remove p from struct spi_engine_message_state

The program pointer p in struct spi_engine_message_state in the AXI SPI
Engine controller driver was assigned but never read so it can be
removed.

Reviewed-by: Kees Cook <[email protected]>
Signed-off-by: David Lechner <[email protected]>
---
drivers/spi/spi-axi-spi-engine.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/spi/spi-axi-spi-engine.c b/drivers/spi/spi-axi-spi-engine.c
index 6177c1a8d56e..d89f75170c9e 100644
--- a/drivers/spi/spi-axi-spi-engine.c
+++ b/drivers/spi/spi-axi-spi-engine.c
@@ -82,8 +82,6 @@ struct spi_engine_program {
* struct spi_engine_message_state - SPI engine per-message state
*/
struct spi_engine_message_state {
- /** @p: Instructions for executing this message. */
- struct spi_engine_program *p;
/** @cmd_length: Number of elements in cmd_buf array. */
unsigned cmd_length;
/** @cmd_buf: Array of commands not yet written to CMD FIFO. */
@@ -543,7 +541,6 @@ static int spi_engine_transfer_one_message(struct spi_controller *host,

/* reinitialize message state for this transfer */
memset(st, 0, sizeof(*st));
- st->p = p;
st->cmd_buf = p->instructions;
st->cmd_length = p->length;
msg->state = st;

--
2.43.2

2024-03-04 16:15:58

by Gustavo A. R. Silva

Subject: Re: [PATCH v2 1/3] spi: axi-spi-engine: remove p from struct spi_engine_message_state

On 04/03/24 10:04, David Lechner wrote:
> The program pointer p in struct spi_engine_message_state in the AXI SPI
> Engine controller driver was assigned but never read so it can be
> removed.
>
> Reviewed-by: Kees Cook <[email protected]>
> Signed-off-by: David Lechner <[email protected]>

Reviewed-by: Gustavo A. R. Silva <[email protected]>

Thanks
--
Gustavo

> ---
> drivers/spi/spi-axi-spi-engine.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/spi/spi-axi-spi-engine.c b/drivers/spi/spi-axi-spi-engine.c
> index 6177c1a8d56e..d89f75170c9e 100644
> --- a/drivers/spi/spi-axi-spi-engine.c
> +++ b/drivers/spi/spi-axi-spi-engine.c
> @@ -82,8 +82,6 @@ struct spi_engine_program {
> * struct spi_engine_message_state - SPI engine per-message state
> */
> struct spi_engine_message_state {
> - /** @p: Instructions for executing this message. */
> - struct spi_engine_program *p;
> /** @cmd_length: Number of elements in cmd_buf array. */
> unsigned cmd_length;
> /** @cmd_buf: Array of commands not yet written to CMD FIFO. */
> @@ -543,7 +541,6 @@ static int spi_engine_transfer_one_message(struct spi_controller *host,
>
> /* reinitialize message state for this transfer */
> memset(st, 0, sizeof(*st));
> - st->p = p;
> st->cmd_buf = p->instructions;
> st->cmd_length = p->length;
> msg->state = st;
>