2024-05-05 07:04:16

by Christophe JAILLET

Subject: [PATCH] leds: is31fl319x: Constify struct regmap_config

'is31fl3190_regmap_config' and 'is31fl3196_regmap_config' are not modified
in this diver and are only used as a const struct regmap_config.

Constifying these structures moves some data to a read-only section, so
increase overall security.

On a x86_64, with allmodconfig:
Before:
text data bss dec hex filename
13827 2002 32 15861 3df5 drivers/leds/leds-is31fl319x.o

After:
text data bss dec hex filename
14467 1370 32 15869 3dfd drivers/leds/leds-is31fl319x.o

Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/leds/leds-is31fl319x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/leds/leds-is31fl319x.c b/drivers/leds/leds-is31fl319x.c
index 66c65741202e..5e1a4d39a107 100644
--- a/drivers/leds/leds-is31fl319x.c
+++ b/drivers/leds/leds-is31fl319x.c
@@ -140,7 +140,7 @@ static const struct reg_default is31fl3190_reg_defaults[] = {
{ IS31FL3190_PWM(2), 0x00 },
};

-static struct regmap_config is31fl3190_regmap_config = {
+static const struct regmap_config is31fl3190_regmap_config = {
.reg_bits = 8,
.val_bits = 8,
.max_register = IS31FL3190_RESET,
@@ -178,7 +178,7 @@ static const struct reg_default is31fl3196_reg_defaults[] = {
{ IS31FL3196_PWM(8), 0x00 },
};

-static struct regmap_config is31fl3196_regmap_config = {
+static const struct regmap_config is31fl3196_regmap_config = {
.reg_bits = 8,
.val_bits = 8,
.max_register = IS31FL3196_REG_CNT,
--
2.45.0

2024-05-31 10:07:09

by Lee Jones

Subject: Re: (subset) [PATCH] leds: is31fl319x: Constify struct regmap_config

On Sun, 05 May 2024 09:03:32 +0200, Christophe JAILLET wrote:
> 'is31fl3190_regmap_config' and 'is31fl3196_regmap_config' are not modified
> in this diver and are only used as a const struct regmap_config.
>
> Constifying these structures moves some data to a read-only section, so
> increase overall security.
>
> On a x86_64, with allmodconfig:
> Before:
> text data bss dec hex filename
> 13827 2002 32 15861 3df5 drivers/leds/leds-is31fl319x.o
>
> [...]

Applied, thanks!

[1/1] leds: is31fl319x: Constify struct regmap_config
commit: eccf45fdbfcbc9890a02d53c0a6c45271c37969e

--
Lee Jones [李琼斯]