2022-08-18 14:12:56

by Vladimir Oltean

Subject: [PATCH devicetree 2/3] arm64: dts: ls1028a: mark enetc port 3 as a DSA master too

The LS1028A switch has 2 internal links to the ENETC controller.

With DSA's ability to support multiple CPU ports, we should mark both
ENETC ports as DSA masters.

Signed-off-by: Vladimir Oltean <[email protected]>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index 3da105119d82..455778936899 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -1170,6 +1170,7 @@ mscc_felix_port5: port@5 {
reg = <5>;
phy-mode = "internal";
status = "disabled";
+ ethernet = <&enetc_port3>;

fixed-link {
speed = <1000>;
--
2.34.1

2022-08-18 14:51:04

by Michael Walle

Subject: Re: [PATCH devicetree 2/3] arm64: dts: ls1028a: mark enetc port 3 as a DSA master too

Am 2022-08-18 16:05, schrieb Vladimir Oltean:
> The LS1028A switch has 2 internal links to the ENETC controller.
>
> With DSA's ability to support multiple CPU ports, we should mark both
> ENETC ports as DSA masters.
>
> Signed-off-by: Vladimir Oltean <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 3da105119d82..455778936899 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -1170,6 +1170,7 @@ mscc_felix_port5: port@5 {
> reg = <5>;
> phy-mode = "internal";
> status = "disabled";
> + ethernet = <&enetc_port3>;

status should be the last property, no?

-michael

2022-08-18 15:13:56

by Michael Walle

Subject: Re: [PATCH devicetree 2/3] arm64: dts: ls1028a: mark enetc port 3 as a DSA master too

Am 2022-08-18 16:45, schrieb Vladimir Oltean:
> On Thu, Aug 18, 2022 at 04:44:28PM +0200, Michael Walle wrote:
>> status should be the last property, no?
>
> idk, should it?

IIRC Shawn pointed that out. If I'm mistaken, then do it for the
consistency within fsl-ls1028a.dtsi :)

-michael

2022-08-18 15:20:37

by Vladimir Oltean

Subject: Re: [PATCH devicetree 2/3] arm64: dts: ls1028a: mark enetc port 3 as a DSA master too

On Thu, Aug 18, 2022 at 04:44:28PM +0200, Michael Walle wrote:
> status should be the last property, no?

idk, should it?

2022-08-22 04:52:19

by Shawn Guo

Subject: Re: [PATCH devicetree 2/3] arm64: dts: ls1028a: mark enetc port 3 as a DSA master too

On Thu, Aug 18, 2022 at 05:08:57PM +0200, Michael Walle wrote:
> Am 2022-08-18 16:45, schrieb Vladimir Oltean:
> > On Thu, Aug 18, 2022 at 04:44:28PM +0200, Michael Walle wrote:
> > > status should be the last property, no?
> >
> > idk, should it?
>
> IIRC Shawn pointed that out. If I'm mistaken, then do it for the
> consistency within fsl-ls1028a.dtsi :)

Yeah, I prefer to have 'status' be the last.

Shawn