2021-01-18 13:54:39

by Tom Rix

Subject: [PATCH] clocksource: mxs_timer: add missing semicolon when DEBUG is defined

From: Tom Rix <[email protected]>

When DEBUG is defined this error occurs

drivers/clocksource/mxs_timer.c:138:1: error:
expected ‘;’ before ‘}’ token

The preceding statement needs a semicolon.

Fixes: eb8703e2ef7c ("clockevents/drivers/mxs: Migrate to new 'set-state' interface")
Signed-off-by: Tom Rix <[email protected]>
---
drivers/clocksource/mxs_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/mxs_timer.c b/drivers/clocksource/mxs_timer.c
index bc96a4cbf26c..55aa6b72d075 100644
--- a/drivers/clocksource/mxs_timer.c
+++ b/drivers/clocksource/mxs_timer.c
@@ -133,7 +133,7 @@ static void mxs_irq_clear(char *state)
timrot_irq_acknowledge();

#ifdef DEBUG
- pr_info("%s: changing mode to %s\n", __func__, state)
+ pr_info("%s: changing mode to %s\n", __func__, state);
#endif /* DEBUG */
}

--
2.27.0

2021-01-18 16:29:16

by Tom Rix

Subject: Re: [PATCH] clocksource: mxs_timer: add missing semicolon when DEBUG is defined

On 1/18/21 7:15 AM, Daniel Lezcano wrote:
> On 18/01/2021 14:49, [email protected] wrote:
>> From: Tom Rix <[email protected]>
>>
>> When DEBUG is defined this error occurs
>>
>> drivers/clocksource/mxs_timer.c:138:1: error:
>> expected ‘;’ before ‘}’ token
>>
>> The preceding statement needs a semicolon.
>>
>> Fixes: eb8703e2ef7c ("clockevents/drivers/mxs: Migrate to new 'set-state' interface")
>> Signed-off-by: Tom Rix <[email protected]>
>> ---
>> drivers/clocksource/mxs_timer.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/clocksource/mxs_timer.c b/drivers/clocksource/mxs_timer.c
>> index bc96a4cbf26c..55aa6b72d075 100644
>> --- a/drivers/clocksource/mxs_timer.c
>> +++ b/drivers/clocksource/mxs_timer.c
>> @@ -133,7 +133,7 @@ static void mxs_irq_clear(char *state)
>> timrot_irq_acknowledge();
>>
>> #ifdef DEBUG
>> - pr_info("%s: changing mode to %s\n", __func__, state)
>> + pr_info("%s: changing mode to %s\n", __func__, state);
>> #endif /* DEBUG */
> Mind to replace by pr_debug and remove the #ifdef ?
ok.
>
>> }
>>
>>
>

2021-01-19 04:40:06

by Daniel Lezcano

Subject: Re: [PATCH] clocksource: mxs_timer: add missing semicolon when DEBUG is defined

On 18/01/2021 14:49, [email protected] wrote:
> From: Tom Rix <[email protected]>
>
> When DEBUG is defined this error occurs
>
> drivers/clocksource/mxs_timer.c:138:1: error:
> expected ‘;’ before ‘}’ token
>
> The preceding statement needs a semicolon.
>
> Fixes: eb8703e2ef7c ("clockevents/drivers/mxs: Migrate to new 'set-state' interface")
> Signed-off-by: Tom Rix <[email protected]>
> ---
> drivers/clocksource/mxs_timer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/mxs_timer.c b/drivers/clocksource/mxs_timer.c
> index bc96a4cbf26c..55aa6b72d075 100644
> --- a/drivers/clocksource/mxs_timer.c
> +++ b/drivers/clocksource/mxs_timer.c
> @@ -133,7 +133,7 @@ static void mxs_irq_clear(char *state)
> timrot_irq_acknowledge();
>
> #ifdef DEBUG
> - pr_info("%s: changing mode to %s\n", __func__, state)
> + pr_info("%s: changing mode to %s\n", __func__, state);
> #endif /* DEBUG */

Mind to replace by pr_debug and remove the #ifdef ?

> }
>
>


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog