2024-01-04 07:42:46

by CK Hu (胡俊光)

[permalink] [raw]
Subject: Re: [PATCH] drm/mediatek/dp: Add the HDCP feature for DisplayPort

Hi, Mac:

On Fri, 2023-11-24 at 16:53 +0800, mac.shen wrote:
> Add tee client application, HDCP 1.x and 2.x authentication for
> DisplayPort
> to support the HDCP feature.
>
> Signed-off-by: mac.shen <[email protected]>
> ---

[snip]

> +#define AN_LEN 8
> +#define AKSV_LEN 5

Is this DRM_HDCP_KSV_LEN?
If all these length are defined in HDCP specification, move these
definition to include/drm/drm_hdcp.h

Regards,
CK

> +#define BKSV_LEN 5
> +#define CERT_LEN 522
> +#define EKM_LEN 16
> +#define M_LEN 16
> +#define ENC_KM_LEN 128
> +#define RXX_LEN 8
> +#define CAPS_LEN 3
> +#define RN_LEN 8
> +#define RIV_LEN 8
> +