2020-08-05 17:24:10

by Grygorii Strashko

[permalink] [raw]
Subject: Re: [PATCH] dmaengine: ti: k3-udma-glue: Fix parameters for rx ring pair request



On 05/08/2020 14:32, Vinod Koul wrote:
> On 05-08-20, 14:27, Peter Ujfalusi wrote:
>> The original commit mixed up the forward and completion ring IDs for the
>> rx flow configuration.
>
> Acked-By: Vinod Koul <[email protected]>
>
>>
>> Fixes: 4927b1ab2047 ("dmaengine: ti: k3-udma: Switch to k3_ringacc_request_rings_pair")
>> Signed-off-by: Peter Ujfalusi <[email protected]>
>> ---
>> Hi Santosh, Vinod,
>>
>> the offending patch was queued via ti SoC tree.
>> Santosh, can you pick up this fix also?

Thank you Peter for catching this - it's valid issue.
but I'd like to note that issue was discovered with private code and
nothing is broken in Master.

Reviewed-by: Grygorii Strashko <[email protected]>

--
Best regards,
grygorii


2020-08-06 17:59:25

by Santosh Shilimkar

[permalink] [raw]
Subject: Re: [PATCH] dmaengine: ti: k3-udma-glue: Fix parameters for rx ring pair request

On 8/5/20 6:17 AM, Grygorii Strashko wrote:
>
>
> On 05/08/2020 14:32, Vinod Koul wrote:
>> On 05-08-20, 14:27, Peter Ujfalusi wrote:
>>> The original commit mixed up the forward and completion ring IDs for the
>>> rx flow configuration.
>>
>> Acked-By: Vinod Koul <[email protected]>
>>
>>>
>>> Fixes: 4927b1ab2047 ("dmaengine: ti: k3-udma: Switch to
>>> k3_ringacc_request_rings_pair")
>>> Signed-off-by: Peter Ujfalusi <[email protected]>
>>> ---
>>> Hi Santosh, Vinod,
>>>
>>> the offending patch was queued via ti SoC tree.
>>> Santosh, can you pick up this fix also?
>
> Thank you Peter for catching this - it's valid issue.
> but I'd like to note that issue was discovered with private code and
> nothing is broken in Master.
>
> Reviewed-by: Grygorii Strashko <[email protected]>
>
Will queue this up for next merge window.

regards,
Santosh