2002-12-19 17:58:24

by Gergely Nagy

Subject: [PATCH][TRIVIAL] drivers/video/tdfxfb.c compile failure (Linux 2.5.52)

Hi!

drivers/video/tdfxfb.c does not compile, because banshee_wait_idle()
is used before declaration. A simple fix follows:

--- linux-2.5.52/drivers/video/tdfxfb.c.old 2002-12-19 18:55:03.000000000 +0100
+++ linux-2.5.52/drivers/video/tdfxfb.c 2002-12-19 18:56:25.000000000 +0100
@@ -166,6 +166,7 @@
static void tdfxfb_copyarea(struct fb_info *info, struct fb_copyarea *area);
static void tdfxfb_imageblit(struct fb_info *info, struct fb_image *image);
static int tdfxfb_cursor(struct fb_info *info, struct fb_cursor *cursor);
+static inline void banshee_wait_idle(struct fb_info *info);

static struct fb_ops tdfxfb_ops = {
.owner = THIS_MODULE,

2002-12-20 18:08:40

by James Simmons

Subject: Re: [Linux-fbdev-devel] [PATCH][TRIVIAL] drivers/video/tdfxfb.c compile failure (Linux 2.5.52)

Thank you. I have other changes as well coming for this driver.


>
> drivers/video/tdfxfb.c does not compile, because banshee_wait_idle()
> is used before declaration. A simple fix follows:
>
> --- linux-2.5.52/drivers/video/tdfxfb.c.old 2002-12-19 18:55:03.000000000 +0100
> +++ linux-2.5.52/drivers/video/tdfxfb.c 2002-12-19 18:56:25.000000000 +0100
> @@ -166,6 +166,7 @@
> static void tdfxfb_copyarea(struct fb_info *info, struct fb_copyarea *area);
> static void tdfxfb_imageblit(struct fb_info *info, struct fb_image *image);
> static int tdfxfb_cursor(struct fb_info *info, struct fb_cursor *cursor);
> +static inline void banshee_wait_idle(struct fb_info *info);
>
> static struct fb_ops tdfxfb_ops = {
> .owner = THIS_MODULE,
>
>
>
> -------------------------------------------------------
> This SF.NET email is sponsored by: Geek Gift Procrastinating?
> Get the perfect geek gift now! Before the Holidays pass you by.
> T H I N K G E E K . C O M http://www.thinkgeek.com/sf/
> _______________________________________________
> Linux-fbdev-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
>