2024-06-12 10:43:53

by Dan Carpenter

[permalink] [raw]
Subject: [PATCH] pinctrl: nuvoton: ma35d1: Fix an IS_ERR() vs NULL check

The fwnode_iomap() function doesn't return error pointers, it returns
NULL. It's the same as of_iomap() in that way. Update the check
accordingly.

Fixes: ecc5bf868673 ("pinctrl: nuvoton: Add ma35d1 pinctrl and GPIO driver")
Signed-off-by: Dan Carpenter <[email protected]>
---
drivers/pinctrl/nuvoton/pinctrl-ma35.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/nuvoton/pinctrl-ma35.c b/drivers/pinctrl/nuvoton/pinctrl-ma35.c
index fb933cddde91..1fa00a23534a 100644
--- a/drivers/pinctrl/nuvoton/pinctrl-ma35.c
+++ b/drivers/pinctrl/nuvoton/pinctrl-ma35.c
@@ -571,8 +571,8 @@ static int ma35_gpiolib_register(struct platform_device *pdev, struct ma35_pinct
static int ma35_get_bank_data(struct ma35_pin_bank *bank)
{
bank->reg_base = fwnode_iomap(bank->fwnode, 0);
- if (IS_ERR(bank->reg_base))
- return PTR_ERR(bank->reg_base);
+ if (!bank->reg_base)
+ return -ENOMEM;

bank->irq = fwnode_irq_get(bank->fwnode, 0);

--
2.43.0