2018-02-28 16:00:21

by Javier González

[permalink] [raw]
Subject: [PATCH V2] lightnvm: pblk: remove unused variable

# Changes since V1:
- Rebase on top of latest 2.0 changes


Javier González (1):
lightnvm: pblk: remove unused variable

drivers/lightnvm/pblk-core.c | 3 ---
1 file changed, 3 deletions(-)

--
2.7.4



2018-02-28 16:57:06

by Javier González

[permalink] [raw]
Subject: [PATCH] lightnvm: pblk: remove unused variable

Remove unused variable after a previous cleanup (a8112b631adb)

Signed-off-by: Javier González <[email protected]>
---
drivers/lightnvm/pblk-core.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index cd663855ee88..b85cdedb5f48 100644
--- a/drivers/lightnvm/pblk-core.c
+++ b/drivers/lightnvm/pblk-core.c
@@ -1082,7 +1082,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
struct nvm_geo *geo = &dev->geo;
struct pblk_line_meta *lm = &pblk->lm;
struct pblk_line_mgmt *l_mg = &pblk->l_mg;
- int nr_bb = 0;
u64 off;
int bit = -1;
int emeta_secs;
@@ -1098,8 +1097,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
bitmap_or(line->map_bitmap, line->map_bitmap, l_mg->bb_aux,
lm->sec_per_line);
line->sec_in_line -= geo->clba;
- if (bit >= lm->emeta_bb)
- nr_bb++;
}

/* Mark smeta metadata sectors as bad sectors */
--
2.7.4


2018-03-01 10:09:16

by Matias Bjørling

[permalink] [raw]
Subject: Re: [PATCH V2] lightnvm: pblk: remove unused variable

On 02/28/2018 04:57 PM, Javier González wrote:
> # Changes since V1:
> - Rebase on top of latest 2.0 changes
>
>
> Javier González (1):
> lightnvm: pblk: remove unused variable
>
> drivers/lightnvm/pblk-core.c | 3 ---
> 1 file changed, 3 deletions(-)
>

Okay if I merge this with Hans' patch? It has not gone upstream yet.


2018-03-01 10:26:55

by Javier González

[permalink] [raw]
Subject: Re: [PATCH V2] lightnvm: pblk: remove unused variable



> On 1 Mar 2018, at 11.07, Matias Bjørling <[email protected]> wrote:
>
> On 02/28/2018 04:57 PM, Javier González wrote:
>> # Changes since V1:
>> - Rebase on top of latest 2.0 changes
>> Javier González (1):
>> lightnvm: pblk: remove unused variable
>> drivers/lightnvm/pblk-core.c | 3 ---
>> 1 file changed, 3 deletions(-)
>
> Okay if I merge this with Hans' patch? It has not gone upstream yet.

Of course!

Javier

Attachments:
signature.asc (849.00 B)
Message signed with OpenPGP

2018-03-01 18:44:35

by Matias Bjørling

[permalink] [raw]
Subject: Re: [PATCH V2] lightnvm: pblk: remove unused variable

On 03/01/2018 11:24 AM, Javier González wrote:
>
>
>> On 1 Mar 2018, at 11.07, Matias Bjørling <[email protected]> wrote:
>>
>> On 02/28/2018 04:57 PM, Javier González wrote:
>>> # Changes since V1:
>>> - Rebase on top of latest 2.0 changes
>>> Javier González (1):
>>> lightnvm: pblk: remove unused variable
>>> drivers/lightnvm/pblk-core.c | 3 ---
>>> 1 file changed, 3 deletions(-)
>>
>> Okay if I merge this with Hans' patch? It has not gone upstream yet.
>
> Of course!
>

Thanks. Applied.