2009-06-15 05:32:58

by Li Zefan

Subject: [PATCH] sched: remove unneeded __ref tag

Those two functions no longer call alloc_bootmmem_cpumask_var(), so
no need to tag them with __init_refok.

Signed-off-by: Li Zefan <[email protected]>
---
kernel/sched.c | 2 +-
kernel/sched_cpupri.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index 6032f51..54e47bc 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -7828,7 +7828,7 @@ static void rq_attach_root(struct rq *rq, struct root_domain *rd)
free_rootdomain(old_rd);
}

-static int __init_refok init_rootdomain(struct root_domain *rd, bool bootmem)
+static int init_rootdomain(struct root_domain *rd, bool bootmem)
{
gfp_t gfp = GFP_KERNEL;

diff --git a/kernel/sched_cpupri.c b/kernel/sched_cpupri.c
index 7deffc9..e6c2517 100644
--- a/kernel/sched_cpupri.c
+++ b/kernel/sched_cpupri.c
@@ -152,7 +152,7 @@ void cpupri_set(struct cpupri *cp, int cpu, int newpri)
*
* Returns: -ENOMEM if memory fails.
*/
-int __init_refok cpupri_init(struct cpupri *cp, bool bootmem)
+int cpupri_init(struct cpupri *cp, bool bootmem)
{
gfp_t gfp = GFP_KERNEL;
int i;
--
1.5.4.rc3

2009-06-15 05:41:29

by Pekka Enberg

Subject: Re: [PATCH] sched: remove unneeded __ref tag

On Mon, Jun 15, 2009 at 8:34 AM, Li Zefan<[email protected]> wrote:
> Those two functions no longer call alloc_bootmmem_cpumask_var(), so
> no need to tag them with __init_refok.
>
> Signed-off-by: Li Zefan <[email protected]>

Acked-by: Pekka Enberg <[email protected]>

Thanks Li!

> ---
> ?kernel/sched.c ? ? ? ?| ? ?2 +-
> ?kernel/sched_cpupri.c | ? ?2 +-
> ?2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched.c b/kernel/sched.c
> index 6032f51..54e47bc 100644
> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -7828,7 +7828,7 @@ static void rq_attach_root(struct rq *rq, struct root_domain *rd)
> ? ? ? ? ? ? ? ?free_rootdomain(old_rd);
> ?}
>
> -static int __init_refok init_rootdomain(struct root_domain *rd, bool bootmem)
> +static int init_rootdomain(struct root_domain *rd, bool bootmem)
> ?{
> ? ? ? ?gfp_t gfp = GFP_KERNEL;
>
> diff --git a/kernel/sched_cpupri.c b/kernel/sched_cpupri.c
> index 7deffc9..e6c2517 100644
> --- a/kernel/sched_cpupri.c
> +++ b/kernel/sched_cpupri.c
> @@ -152,7 +152,7 @@ void cpupri_set(struct cpupri *cp, int cpu, int newpri)
> ?*
> ?* Returns: -ENOMEM if memory fails.
> ?*/
> -int __init_refok cpupri_init(struct cpupri *cp, bool bootmem)
> +int cpupri_init(struct cpupri *cp, bool bootmem)
> ?{
> ? ? ? ?gfp_t gfp = GFP_KERNEL;
> ? ? ? ?int i;
> --
> 1.5.4.rc3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at ?http://www.tux.org/lkml/
>

2009-06-17 14:19:33

by Li Zefan

Subject: [tip:sched/urgent] sched: Remove unneeded __ref tag

Commit-ID: fd5e1b5dbaa8b4aacc0e251d74182eda37062194
Gitweb: http://git.kernel.org/tip/fd5e1b5dbaa8b4aacc0e251d74182eda37062194
Author: Li Zefan <[email protected]>
AuthorDate: Mon, 15 Jun 2009 13:34:19 +0800
Committer: Ingo Molnar <[email protected]>
CommitDate: Wed, 17 Jun 2009 16:08:04 +0200

sched: Remove unneeded __ref tag

Those two functions no longer call alloc_bootmmem_cpumask_var(),
so no need to tag them with __init_refok.

Signed-off-by: Li Zefan <[email protected]>
Acked-by: Pekka Enberg <[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>


---
kernel/sched.c | 2 +-
kernel/sched_cpupri.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index 8fb88a9..0056795 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -7828,7 +7828,7 @@ static void rq_attach_root(struct rq *rq, struct root_domain *rd)
free_rootdomain(old_rd);
}

-static int __init_refok init_rootdomain(struct root_domain *rd, bool bootmem)
+static int init_rootdomain(struct root_domain *rd, bool bootmem)
{
gfp_t gfp = GFP_KERNEL;

diff --git a/kernel/sched_cpupri.c b/kernel/sched_cpupri.c
index 7deffc9..e6c2517 100644
--- a/kernel/sched_cpupri.c
+++ b/kernel/sched_cpupri.c
@@ -152,7 +152,7 @@ void cpupri_set(struct cpupri *cp, int cpu, int newpri)
*
* Returns: -ENOMEM if memory fails.
*/
-int __init_refok cpupri_init(struct cpupri *cp, bool bootmem)
+int cpupri_init(struct cpupri *cp, bool bootmem)
{
gfp_t gfp = GFP_KERNEL;
int i;