Hi all,
Today's linux-next build (x86_64 allmodconfig) failed like this:
net/wireless/scan.c: In function 'cfg80211_inform_bss':
net/wireless/scan.c:499: error: implicit declaration of function 'kmemleak_ignore'
Caused by commit 74ce35c0d2261896ed4d49799311a894520f7a94 ("cfg80211:
clear cfg80211_inform_bss() from kmemleak reports") from the wireless
tree (which should have included linux/kmemleak.h into
net/wireless/scan.c). Some interaction with the slab tree has exposed
this.
I have reverted the above commit for today.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
Hi Stephen,
On Mon, Sep 7, 2009 at 8:37 AM, Stephen Rothwell<[email protected]> wrote:
> Hi all,
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> net/wireless/scan.c: In function 'cfg80211_inform_bss':
> net/wireless/scan.c:499: error: implicit declaration of function 'kmemleak_ignore'
>
> Caused by commit 74ce35c0d2261896ed4d49799311a894520f7a94 ("cfg80211:
> clear cfg80211_inform_bss() from kmemleak reports") from the wireless
> tree (which should have included linux/kmemleak.h into
> net/wireless/scan.c). ?Some interaction with the slab tree has exposed
> this.
>
> I have reverted the above commit for today.
AFAICT, you're interested in kmemleak.git, not slab.git. Catalin?
Pekka
Hi Pekka,
On Mon, 7 Sep 2009 09:10:18 +0300 Pekka Enberg <[email protected]> wrote:
>
> AFAICT, you're interested in kmemleak.git, not slab.git. Catalin?
I first got the error after merging the slab tree ... the kmemleak tree
is merged much later.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
Hi Stephen,
On Mon, 7 Sep 2009 09:10:18 +0300 Pekka Enberg <[email protected]> wrote:
> > AFAICT, you're interested in kmemleak.git, not slab.git. Catalin?
On Mon, 2009-09-07 at 17:31 +1000, Stephen Rothwell wrote:
> I first got the error after merging the slab tree ... the kmemleak tree
> is merged much later.
Aah, let me guess, CONFIG_SLQB? I guess I'll just rebase the damn tree
and make it non-default. We need that anyway if we want to merge it to
2.6.32. I'll take a stab at it later this evening (my time zone).
Pekka
Hi Pekka,
On Mon, 07 Sep 2009 10:43:46 +0300 Pekka Enberg <[email protected]> wrote:
>
> Aah, let me guess, CONFIG_SLQB? I guess I'll just rebase the damn tree
That would be my guess.
> and make it non-default. We need that anyway if we want to merge it to
> 2.6.32. I'll take a stab at it later this evening (my time zone).
OK. This breakage still needs to be fixed in the wireless tree, though.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
On Mon, 2009-09-07 at 09:10 +0300, Pekka Enberg wrote:
> Hi Stephen,
>
> On Mon, Sep 7, 2009 at 8:37 AM, Stephen Rothwell<[email protected]> wrote:
> > Hi all,
> >
> > Today's linux-next build (x86_64 allmodconfig) failed like this:
> >
> > net/wireless/scan.c: In function 'cfg80211_inform_bss':
> > net/wireless/scan.c:499: error: implicit declaration of function 'kmemleak_ignore'
> >
> > Caused by commit 74ce35c0d2261896ed4d49799311a894520f7a94 ("cfg80211:
> > clear cfg80211_inform_bss() from kmemleak reports") from the wireless
> > tree (which should have included linux/kmemleak.h into
> > net/wireless/scan.c). Some interaction with the slab tree has exposed
> > this.
> >
> > I have reverted the above commit for today.
>
> AFAICT, you're interested in kmemleak.git, not slab.git. Catalin?
I think that's a commit from Luis. It shouldn't have been merged in the
first instance anyway (we shouldn't randomly ignore kmemleak reports
unless we know for sure why kmemleak thinks it is a leak and we should
write a comment explaining why).
--
Catalin
On Mon, Sep 07, 2009 at 10:43:46AM +0300, Pekka Enberg wrote:
> Aah, let me guess, CONFIG_SLQB? I guess I'll just rebase the damn tree
> and make it non-default. We need that anyway if we want to merge it to
> 2.6.32. I'll take a stab at it later this evening (my time zone).
Will SLQB be merged during the next merge window? Just realized that s390
doesn't boot with CONFIG_SLQB (crashes before the console is active).
I tend to ignore bugs which seem to be related to SLQB in linux-next,
but if it gets merged I might need to look deeper into this.
Hi Heiko,
On Mon, Sep 07, 2009 at 10:43:46AM +0300, Pekka Enberg wrote:
>> Aah, let me guess, CONFIG_SLQB? I guess I'll just rebase the damn tree
>> and make it non-default. We need that anyway if we want to merge it to
>> 2.6.32. I'll take a stab at it later this evening (my time zone).
On Mon, Sep 7, 2009 at 12:04 PM, Heiko
Carstens<[email protected]> wrote:
> Will SLQB be merged during the next merge window? Just realized that s390
> doesn't boot with CONFIG_SLQB (crashes before the console is active).
>
> I tend to ignore bugs which seem to be related to SLQB in linux-next,
> but if it gets merged I might need to look deeper into this.
Yes, that's the plan. That said, there's a long-standing PPC boot-time
bug in SLQB that's still unfixed which could affect other archs as
well AFAICT. Help in tracking that down would be appreciated as Nick
seems to be busy atm.
I am not completely happy with sending something that's known to be
broken to Linus. However, the problem is not getting fixed in slab.git
and everyone seems to be in favor of merging the allocator and mark it
as "experimental" so I'll probably just send it Linus' way for 2.6.32
and let him decide whether to take it or not.
Pekka
On Mon, Sep 07, 2009 at 01:35:09AM -0700, Catalin Marinas wrote:
> On Mon, 2009-09-07 at 09:10 +0300, Pekka Enberg wrote:
> > Hi Stephen,
> >
> > On Mon, Sep 7, 2009 at 8:37 AM, Stephen Rothwell<[email protected]> wrote:
> > > Hi all,
> > >
> > > Today's linux-next build (x86_64 allmodconfig) failed like this:
> > >
> > > net/wireless/scan.c: In function 'cfg80211_inform_bss':
> > > net/wireless/scan.c:499: error: implicit declaration of function 'kmemleak_ignore'
> > >
> > > Caused by commit 74ce35c0d2261896ed4d49799311a894520f7a94 ("cfg80211:
> > > clear cfg80211_inform_bss() from kmemleak reports") from the wireless
> > > tree (which should have included linux/kmemleak.h into
> > > net/wireless/scan.c). Some interaction with the slab tree has exposed
> > > this.
> > >
> > > I have reverted the above commit for today.
> >
> > AFAICT, you're interested in kmemleak.git, not slab.git. Catalin?
>
> I think that's a commit from Luis. It shouldn't have been merged in the
> first instance anyway (we shouldn't randomly ignore kmemleak reports
> unless we know for sure why kmemleak thinks it is a leak and we should
> write a comment explaining why).
I asked John to revert it, feel free to do the same.
Luis