2020-11-27 19:21:43

by Tom Rix

Subject: [PATCH] [SCSI] sym53c8xx: remove trailing semicolon in macro definition

From: Tom Rix <[email protected]>

The macro use will already have a semicolon.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/scsi/sym53c8xx_2/sym_glue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/sym53c8xx_2/sym_glue.c b/drivers/scsi/sym53c8xx_2/sym_glue.c
index d9a045f9858c..f3b3345c1766 100644
--- a/drivers/scsi/sym53c8xx_2/sym_glue.c
+++ b/drivers/scsi/sym53c8xx_2/sym_glue.c
@@ -1001,12 +1001,12 @@ static int is_keyword(char *ptr, int len, char *verb)
#define SKIP_SPACES(ptr, len) \
if ((arg_len = sym_skip_spaces(ptr, len)) < 1) \
return -EINVAL; \
- ptr += arg_len; len -= arg_len;
+ ptr += arg_len; len -= arg_len

#define GET_INT_ARG(ptr, len, v) \
if (!(arg_len = get_int_arg(ptr, len, &(v)))) \
return -EINVAL; \
- ptr += arg_len; len -= arg_len;
+ ptr += arg_len; len -= arg_len


/*
--
2.18.4

2020-11-28 00:35:00

by James Bottomley

Subject: Re: [PATCH] [SCSI] sym53c8xx: remove trailing semicolon in macro definition

On Fri, 2020-11-27 at 10:29 -0800, [email protected] wrote:
> From: Tom Rix <[email protected]>
>
> The macro use will already have a semicolon.
>
> Signed-off-by: Tom Rix <[email protected]>
> ---
> drivers/scsi/sym53c8xx_2/sym_glue.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/sym53c8xx_2/sym_glue.c
> b/drivers/scsi/sym53c8xx_2/sym_glue.c
> index d9a045f9858c..f3b3345c1766 100644
> --- a/drivers/scsi/sym53c8xx_2/sym_glue.c
> +++ b/drivers/scsi/sym53c8xx_2/sym_glue.c
> @@ -1001,12 +1001,12 @@ static int is_keyword(char *ptr, int len,
> char *verb)
> #define SKIP_SPACES(ptr, len)
> \
> if ((arg_len = sym_skip_spaces(ptr, len)) < 1)
> \
> return -EINVAL;
> \
> - ptr += arg_len; len -= arg_len;
> + ptr += arg_len; len -= arg_len
>
> #define GET_INT_ARG(ptr, len, v)
> \
> if (!(arg_len = get_int_arg(ptr, len, &(v))))
> \
> return -EINVAL;
> \
> - ptr += arg_len; len -= arg_len;
> + ptr += arg_len; len -= arg_len

Those macros have the wrong form which can lead to actual bugs and this
cosmetic change does nothing to fix it. If the goal here is to get the
code base into better shape, please fix the bugs.

James