Update GCC clocks and add support for GDSCs for QDU1000 and QRU1000 SoCs.
Also, add support for v2 variant as well.
Imran Shaik (2):
dt-bindings: clock: Update GCC clocks for QDU1000 and QRU1000 SoCs
clk: qcom: gcc-qdu1000: Update GCC clocks and add support for GDSCs
.../bindings/clock/qcom,qdu1000-gcc.yaml | 6 +-
drivers/clk/qcom/gcc-qdu1000.c | 162 ++++++++++++------
include/dt-bindings/clock/qcom,qdu1000-gcc.h | 4 +-
3 files changed, 118 insertions(+), 54 deletions(-)
--
2.25.1
Update the qcom GCC clock bindings and add v2 compatible string for QDU1000
and QRU1000 SoCs.
Signed-off-by: Taniya Das <[email protected]>
Signed-off-by: Imran Shaik <[email protected]>
---
.../devicetree/bindings/clock/qcom,qdu1000-gcc.yaml | 6 +++++-
include/dt-bindings/clock/qcom,qdu1000-gcc.h | 4 +++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml
index 767a9d03aa32..030953d258c1 100644
--- a/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml
@@ -8,6 +8,8 @@ title: Qualcomm Global Clock & Reset Controller for QDU1000 and QRU1000
maintainers:
- Melody Olvera <[email protected]>
+ - Taniya Das <[email protected]>
+ - Imran Shaik <[email protected]>
description: |
Qualcomm global clock control module which supports the clocks, resets and
@@ -17,7 +19,9 @@ description: |
properties:
compatible:
- const: qcom,qdu1000-gcc
+ enum:
+ - qcom,qdu1000-gcc
+ - qcom,qdu1000-gcc-v2
clocks:
items:
diff --git a/include/dt-bindings/clock/qcom,qdu1000-gcc.h b/include/dt-bindings/clock/qcom,qdu1000-gcc.h
index ddbc6b825e80..2fd36cbfddbb 100644
--- a/include/dt-bindings/clock/qcom,qdu1000-gcc.h
+++ b/include/dt-bindings/clock/qcom,qdu1000-gcc.h
@@ -1,6 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
/*
- * Copyright (c) 2021-2022, Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023, Qualcomm Innovation Center, Inc. All rights reserved.
*/
#ifndef _DT_BINDINGS_CLK_QCOM_GCC_QDU1000_H
@@ -138,6 +138,8 @@
#define GCC_AGGRE_NOC_ECPRI_GSI_CLK 128
#define GCC_PCIE_0_PIPE_CLK_SRC 129
#define GCC_PCIE_0_PHY_AUX_CLK_SRC 130
+#define GCC_GPLL1_OUT_EVEN 131
+#define GCC_DDRSS_ECPRI_GSI_CLK 132
/* GCC resets */
#define GCC_ECPRI_CC_BCR 0
--
2.25.1
On 16/06/2023 12:49, Imran Shaik wrote:
> Update the qcom GCC clock bindings and add v2 compatible string for QDU1000
> and QRU1000 SoCs.
>
> Signed-off-by: Taniya Das <[email protected]>
> Signed-off-by: Imran Shaik <[email protected]>
> ---
> .../devicetree/bindings/clock/qcom,qdu1000-gcc.yaml | 6 +++++-
> include/dt-bindings/clock/qcom,qdu1000-gcc.h | 4 +++-
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml
> index 767a9d03aa32..030953d258c1 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml
> @@ -8,6 +8,8 @@ title: Qualcomm Global Clock & Reset Controller for QDU1000 and QRU1000
>
> maintainers:
> - Melody Olvera <[email protected]>
> + - Taniya Das <[email protected]>
> + - Imran Shaik <[email protected]>
I appreciate adding more maintainers, it is welcomed and needed.
However many of Qualcomm folks, including some of you, did not care
enough to fix their old/incorrect email in existing entries, thus we
have hundreds of wrong addresses and email bounces.
We already raised this internally and publicly, with just small effect,
so I am not sure what to do more. For me, allowing to have outdated
email in maintainers is an easiest proof that maintainer does not care.
Adding more maintainer entries, while maintainer does not care, would
not feel right. Maybe let's start with fixing existing entries?
>
> description: |
> Qualcomm global clock control module which supports the clocks, resets and
> @@ -17,7 +19,9 @@ description: |
>
> properties:
> compatible:
> - const: qcom,qdu1000-gcc
> + enum:
> + - qcom,qdu1000-gcc
> + - qcom,qdu1000-gcc-v2
It's the same block, isn't it? What is the "v2" exactly?
Best regards,
Krzysztof
On 16.06.2023 12:49, Imran Shaik wrote:
> Update GCC clocks and add support for GDSCs for QDU1000 and QRU1000 SoCs.
> Also, add support for v2 variant as well.
Does that imply the first submission concerned v1/pre-mass-production chips?
We usually don't support these upstream, as they are rather short-lived and
never (officially, anyway) escape Qualcomm internal..
Konrad
>
> Imran Shaik (2):
> dt-bindings: clock: Update GCC clocks for QDU1000 and QRU1000 SoCs
> clk: qcom: gcc-qdu1000: Update GCC clocks and add support for GDSCs
>
> .../bindings/clock/qcom,qdu1000-gcc.yaml | 6 +-
> drivers/clk/qcom/gcc-qdu1000.c | 162 ++++++++++++------
> include/dt-bindings/clock/qcom,qdu1000-gcc.h | 4 +-
> 3 files changed, 118 insertions(+), 54 deletions(-)
>
On 16/06/2023 13:33, Krzysztof Kozlowski wrote:
> On 16/06/2023 12:49, Imran Shaik wrote:
>> Update the qcom GCC clock bindings and add v2 compatible string for QDU1000
>> and QRU1000 SoCs.
>>
>> Signed-off-by: Taniya Das <[email protected]>
>> Signed-off-by: Imran Shaik <[email protected]>
>> ---
>> .../devicetree/bindings/clock/qcom,qdu1000-gcc.yaml | 6 +++++-
>> include/dt-bindings/clock/qcom,qdu1000-gcc.h | 4 +++-
>> 2 files changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml
>> index 767a9d03aa32..030953d258c1 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml
>> @@ -8,6 +8,8 @@ title: Qualcomm Global Clock & Reset Controller for QDU1000 and QRU1000
>>
>> maintainers:
>> - Melody Olvera <[email protected]>
>> + - Taniya Das <[email protected]>
>> + - Imran Shaik <[email protected]>
>
> I appreciate adding more maintainers, it is welcomed and needed.
>
> However many of Qualcomm folks, including some of you, did not care
> enough to fix their old/incorrect email in existing entries, thus we
> have hundreds of wrong addresses and email bounces.
>
> We already raised this internally and publicly, with just small effect,
> so I am not sure what to do more. For me, allowing to have outdated
> email in maintainers is an easiest proof that maintainer does not care.
> Adding more maintainer entries, while maintainer does not care, would
> not feel right. Maybe let's start with fixing existing entries?
+Cc Alex,
Let me emphasize more, because I did not see any follow up patches since
my previous email - there are many, many stale maintainer entries from
Qualcomm. Several of them have codeaurora.org email. Some have just old
emails of folks who left.
Can we expect fixing these?
Best regards,
Krzysztof
On 6/16/2023 4:51 PM, Konrad Dybcio wrote:
> On 16.06.2023 12:49, Imran Shaik wrote:
>> Update GCC clocks and add support for GDSCs for QDU1000 and QRU1000 SoCs.
>> Also, add support for v2 variant as well.
> Does that imply the first submission concerned v1/pre-mass-production chips?
>
> We usually don't support these upstream, as they are rather short-lived and
> never (officially, anyway) escape Qualcomm internal..
>
> Konrad
Sure, will update the next series to support only the latest hardware
version.
Thanks,
Imran
>>
>> Imran Shaik (2):
>> dt-bindings: clock: Update GCC clocks for QDU1000 and QRU1000 SoCs
>> clk: qcom: gcc-qdu1000: Update GCC clocks and add support for GDSCs
>>
>> .../bindings/clock/qcom,qdu1000-gcc.yaml | 6 +-
>> drivers/clk/qcom/gcc-qdu1000.c | 162 ++++++++++++------
>> include/dt-bindings/clock/qcom,qdu1000-gcc.h | 4 +-
>> 3 files changed, 118 insertions(+), 54 deletions(-)
>>
On 6/22/2023 7:15 PM, Krzysztof Kozlowski wrote:
> On 16/06/2023 13:33, Krzysztof Kozlowski wrote:
>> On 16/06/2023 12:49, Imran Shaik wrote:
>>> Update the qcom GCC clock bindings and add v2 compatible string for QDU1000
>>> and QRU1000 SoCs.
>>>
>>> Signed-off-by: Taniya Das <[email protected]>
>>> Signed-off-by: Imran Shaik <[email protected]>
>>> ---
>>> .../devicetree/bindings/clock/qcom,qdu1000-gcc.yaml | 6 +++++-
>>> include/dt-bindings/clock/qcom,qdu1000-gcc.h | 4 +++-
>>> 2 files changed, 8 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml
>>> index 767a9d03aa32..030953d258c1 100644
>>> --- a/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml
>>> +++ b/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml
>>> @@ -8,6 +8,8 @@ title: Qualcomm Global Clock & Reset Controller for QDU1000 and QRU1000
>>>
>>> maintainers:
>>> - Melody Olvera <[email protected]>
>>> + - Taniya Das <[email protected]>
>>> + - Imran Shaik <[email protected]>
>>
>> I appreciate adding more maintainers, it is welcomed and needed.
>>
>> However many of Qualcomm folks, including some of you, did not care
>> enough to fix their old/incorrect email in existing entries, thus we
>> have hundreds of wrong addresses and email bounces.
>>
>> We already raised this internally and publicly, with just small effect,
>> so I am not sure what to do more. For me, allowing to have outdated
>> email in maintainers is an easiest proof that maintainer does not care.
>> Adding more maintainer entries, while maintainer does not care, would
>> not feel right. Maybe let's start with fixing existing entries?
>
> +Cc Alex,
>
> Let me emphasize more, because I did not see any follow up patches since
> my previous email - there are many, many stale maintainer entries from
> Qualcomm. Several of them have codeaurora.org email. Some have just old
> emails of folks who left.
>
> Can we expect fixing these?
Sure, will post a separate clean up patch for fixing all the
old/incorrect maintainers email addresses from all the binding files.
Thanks,
Imran
>
> Best regards,
> Krzysztof
>