2021-03-23 09:39:15

by Yang Li

[permalink] [raw]
Subject: [PATCH v2] drm/omap: dsi: Add missing IRQF_ONESHOT

fixed the following coccicheck:
./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with
no primary handler requested without IRQF_ONESHOT

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---

Change in v2:
-Modify the fourth parameter, not the first

drivers/gpu/drm/omapdrm/dss/dsi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
index b31d750..5f1722b 100644
--- a/drivers/gpu/drm/omapdrm/dss/dsi.c
+++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
@@ -4327,7 +4327,8 @@ static int omap_dsi_register_te_irq(struct dsi_data *dsi,
irq_set_status_flags(te_irq, IRQ_NOAUTOEN);

err = request_threaded_irq(te_irq, NULL, omap_dsi_te_irq_handler,
- IRQF_TRIGGER_RISING, "TE", dsi);
+ IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+ "TE", dsi);
if (err) {
dev_err(dsi->dev, "request irq failed with %d\n", err);
gpiod_put(dsi->te_gpio);
--
1.8.3.1


2021-03-23 11:18:04

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH v2] drm/omap: dsi: Add missing IRQF_ONESHOT

Hi,

On Tue, Mar 23, 2021 at 05:34:53PM +0800, Yang Li wrote:
> fixed the following coccicheck:
> ./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with
> no primary handler requested without IRQF_ONESHOT
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---

Reviewed-by: Sebastian Reichel <[email protected]>

Also maybe add this, so that it is properly backported. OTOH old code did
not have IRQF_ONESHOT either.

Fixes: 4c1b935fea54 ("drm/omap: dsi: move TE GPIO handling into core")

-- Sebastian

> Change in v2:
> -Modify the fourth parameter, not the first
>
> drivers/gpu/drm/omapdrm/dss/dsi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
> index b31d750..5f1722b 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dsi.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
> @@ -4327,7 +4327,8 @@ static int omap_dsi_register_te_irq(struct dsi_data *dsi,
> irq_set_status_flags(te_irq, IRQ_NOAUTOEN);
>
> err = request_threaded_irq(te_irq, NULL, omap_dsi_te_irq_handler,
> - IRQF_TRIGGER_RISING, "TE", dsi);
> + IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> + "TE", dsi);
> if (err) {
> dev_err(dsi->dev, "request irq failed with %d\n", err);
> gpiod_put(dsi->te_gpio);
> --
> 1.8.3.1
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Attachments:
(No filename) (1.58 kB)
 signature.asc (849.00 B)
 Download all attachments

2021-03-26 07:26:00

by Tomi Valkeinen

[permalink] [raw]
Subject: Re: [PATCH v2] drm/omap: dsi: Add missing IRQF_ONESHOT

On 23/03/2021 13:15, Sebastian Reichel wrote:
> Hi,
>
> On Tue, Mar 23, 2021 at 05:34:53PM +0800, Yang Li wrote:
>> fixed the following coccicheck:
>> ./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with
>> no primary handler requested without IRQF_ONESHOT
>>
>> Reported-by: Abaci Robot <[email protected]>
>> Signed-off-by: Yang Li <[email protected]>
>> ---
>
> Reviewed-by: Sebastian Reichel <[email protected]>
>
> Also maybe add this, so that it is properly backported. OTOH old code did
> not have IRQF_ONESHOT either.
>
> Fixes: 4c1b935fea54 ("drm/omap: dsi: move TE GPIO handling into core")

Thanks, I have applied this.

Tomi