2020-01-20 12:28:52

by Chen Wandun

Subject: [PATCH next] net/mlx5: make the symbol 'ESW_POOLS' static

Fix the following sparse warning:
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c:35:20: warning: symbol 'ESW_POOLS' was not declared. Should it be static?

Fixes: 39ac237ce009 ("net/mlx5: E-Switch, Refactor chains and priorities")
Signed-off-by: Chen Wandun <[email protected]>
---
.../ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c
index 3a60eb5360bd..c5a446e295aa 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c
@@ -32,10 +32,10 @@
* pools.
*/
#define ESW_SIZE (16 * 1024 * 1024)
-const unsigned int ESW_POOLS[] = { 4 * 1024 * 1024,
- 1 * 1024 * 1024,
- 64 * 1024,
- 4 * 1024, };
+static const unsigned int ESW_POOLS[] = { 4 * 1024 * 1024,
+ 1 * 1024 * 1024,
+ 64 * 1024,
+ 4 * 1024, };

struct mlx5_esw_chains_priv {
struct rhashtable chains_ht;
--
2.17.1

2020-01-20 14:34:12

by Paul Blakey

Subject: Re: [PATCH next] net/mlx5: make the symbol 'ESW_POOLS' static

On 1/20/2020 2:41 PM, Chen Wandun wrote:
> Fix the following sparse warning:
> drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c:35:20: warning: symbol 'ESW_POOLS' was not declared. Should it be static?
>
> Fixes: 39ac237ce009 ("net/mlx5: E-Switch, Refactor chains and priorities")
> Signed-off-by: Chen Wandun <[email protected]>
> ---
> .../ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c
> index 3a60eb5360bd..c5a446e295aa 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c
> @@ -32,10 +32,10 @@
> * pools.
> */
> #define ESW_SIZE (16 * 1024 * 1024)
> -const unsigned int ESW_POOLS[] = { 4 * 1024 * 1024,
> - 1 * 1024 * 1024,
> - 64 * 1024,
> - 4 * 1024, };
> +static const unsigned int ESW_POOLS[] = { 4 * 1024 * 1024,
> + 1 * 1024 * 1024,
> + 64 * 1024,
> + 4 * 1024, };
>
> struct mlx5_esw_chains_priv {
> struct rhashtable chains_ht;

Acked-by: Paul Blakey <[email protected]>

2020-01-21 20:45:20

by Saeed Mahameed

Subject: Re: [PATCH next] net/mlx5: make the symbol 'ESW_POOLS' static

On Mon, 2020-01-20 at 14:33 +0000, Paul Blakey wrote:
> On 1/20/2020 2:41 PM, Chen Wandun wrote:
> > Fix the following sparse warning:
> > drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c:3
> > 5:20: warning: symbol 'ESW_POOLS' was not declared. Should it be
> > static?
> >
> > Fixes: 39ac237ce009 ("net/mlx5: E-Switch, Refactor chains and
> > priorities")
> > Signed-off-by: Chen Wandun <[email protected]>
> > ---
> > .../ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c | 8
> > ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git
> > a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c
> > b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c
> > index 3a60eb5360bd..c5a446e295aa 100644
> > ---
> > a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c
> > +++
> > b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c
> > @@ -32,10 +32,10 @@
> > * pools.
> > */
> > #define ESW_SIZE (16 * 1024 * 1024)
> > -const unsigned int ESW_POOLS[] = { 4 * 1024 * 1024,
> > - 1 * 1024 * 1024,
> > - 64 * 1024,
> > - 4 * 1024, };
> > +static const unsigned int ESW_POOLS[] = { 4 * 1024 * 1024,
> > + 1 * 1024 * 1024,
> > + 64 * 1024,
> > + 4 * 1024, };
> >
> > struct mlx5_esw_chains_priv {
> > struct rhashtable chains_ht;
>
> Acked-by: Paul Blakey <[email protected]>
>

Applied to net-next-mlx5,

Thanks!