Hello,
Some devices have a 4-pin jack instead of a 3-pin and currently the
WM8903 configuration is hardcoded to the case of 3-pin jack in the
Tegra's ASoC driver. A new device-tree property is required in order
to convey that hardware has a 4-pin jack, and thus, microphone's
detection needs to be done in a different way.
In particular this is needed for Acer A500 tablet device that has
a 4-pin headset jack, otherwise userspace sees headset instead of
headphones and internal microphone isn't enabled by ALSA UCM rule
when it should be. Please review and apply, thanks in advance.
Dmitry Osipenko (2):
dt-bindings: sound: tegra-wm8903: Document new nvidia,headset property
ASoC: tegra: tegra_wm8903: Support nvidia,headset property
.../devicetree/bindings/sound/nvidia,tegra-audio-wm8903.txt | 1 +
sound/soc/tegra/tegra_wm8903.c | 6 +++++-
2 files changed, 6 insertions(+), 1 deletion(-)
--
2.25.1
30.03.2020 23:40, Dmitry Osipenko пишет:
> Hello,
>
> Some devices have a 4-pin jack instead of a 3-pin and currently the
> WM8903 configuration is hardcoded to the case of 3-pin jack in the
> Tegra's ASoC driver. A new device-tree property is required in order
> to convey that hardware has a 4-pin jack, and thus, microphone's
> detection needs to be done in a different way.
>
> In particular this is needed for Acer A500 tablet device that has
> a 4-pin headset jack, otherwise userspace sees headset instead of
> headphones and internal microphone isn't enabled by ALSA UCM rule
> when it should be. Please review and apply, thanks in advance.
>
> Dmitry Osipenko (2):
> dt-bindings: sound: tegra-wm8903: Document new nvidia,headset property
> ASoC: tegra: tegra_wm8903: Support nvidia,headset property
>
> .../devicetree/bindings/sound/nvidia,tegra-audio-wm8903.txt | 1 +
> sound/soc/tegra/tegra_wm8903.c | 6 +++++-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
Jon / Stephen, are you okay with this patchset? Could you please ack it?
Thanks in advance.
On 4/9/20 8:52 AM, Dmitry Osipenko wrote:
> 30.03.2020 23:40, Dmitry Osipenko пишет:
>> Hello,
>>
>> Some devices have a 4-pin jack instead of a 3-pin and currently the
>> WM8903 configuration is hardcoded to the case of 3-pin jack in the
>> Tegra's ASoC driver. A new device-tree property is required in order
>> to convey that hardware has a 4-pin jack, and thus, microphone's
>> detection needs to be done in a different way.
>>
>> In particular this is needed for Acer A500 tablet device that has
>> a 4-pin headset jack, otherwise userspace sees headset instead of
>> headphones and internal microphone isn't enabled by ALSA UCM rule
>> when it should be. Please review and apply, thanks in advance.
>>
>> Dmitry Osipenko (2):
>> dt-bindings: sound: tegra-wm8903: Document new nvidia,headset property
>> ASoC: tegra: tegra_wm8903: Support nvidia,headset property
>>
>> .../devicetree/bindings/sound/nvidia,tegra-audio-wm8903.txt | 1 +
>> sound/soc/tegra/tegra_wm8903.c | 6 +++++-
>> 2 files changed, 6 insertions(+), 1 deletion(-)
>>
>
> Jon / Stephen, are you okay with this patchset? Could you please ack it?
> Thanks in advance.
It looks plausible based on commit descriptions, but I don't remember
the details of those APIs well enough to actually review the code change.
09.04.2020 19:54, Stephen Warren пишет:
...
>> Jon / Stephen, are you okay with this patchset? Could you please ack it?
>> Thanks in advance.
>
> It looks plausible based on commit descriptions, but I don't remember
> the details of those APIs well enough to actually review the code change.
>
The code change doesn't affect any of the old users, so it should be
safe anyways.
I understand that you don't feel comfortable to give an ACK if you're
unsure, but I assume that Jon is in the same position, and thus, I'm not
sure how to move forward.
Mark, could you please help with reviewing this series?
On Thu, Apr 09, 2020 at 08:13:54PM +0300, Dmitry Osipenko wrote:
> The code change doesn't affect any of the old users, so it should be
> safe anyways.
> I understand that you don't feel comfortable to give an ACK if you're
> unsure, but I assume that Jon is in the same position, and thus, I'm not
> sure how to move forward.
> Mark, could you please help with reviewing this series?
It is currently the merge window. Nothing other than bug fixes is going
to get applied until the merge window is over, probably Sunday or Monday.
09.04.2020 20:29, Mark Brown пишет:
> On Thu, Apr 09, 2020 at 08:13:54PM +0300, Dmitry Osipenko wrote:
>
>> The code change doesn't affect any of the old users, so it should be
>> safe anyways.
>
>> I understand that you don't feel comfortable to give an ACK if you're
>> unsure, but I assume that Jon is in the same position, and thus, I'm not
>> sure how to move forward.
>
>> Mark, could you please help with reviewing this series?
>
> It is currently the merge window. Nothing other than bug fixes is going
> to get applied until the merge window is over, probably Sunday or Monday.
>
Will be awesome, thank you :)