2014-04-09 18:20:41

by Valdis Klētnieks

[permalink] [raw]
Subject: pstore wierdness on Dell Latitude E6530.

For some reason, /sys/fs/pstore has 537 files in it, all called 'console-efi',
all having inode number 8021, and all consisting of the same one line:

[/sys/fs/pstore] cat console-efi
[ 1.567734] pci 0000:00:1c.1: PCI bridge to [bus 03]
[/sys/fs/pstore] ls | uniq -c
537 console-efi
[/sys/fs/pstore] cat console-efi
[ 1.567734] pci 0000:00:1c.1: PCI bridge to [bus 03]
[/sys/fs/pstore] grep . * | uniq -c
537 console-efi:[ 1.567734] pci 0000:00:1c.1: PCI bridge to [bus 03]
[/sys/fs/pstore] ls -li | head
total 0
8021 -r--r--r--. 1 root root 56 Aug 13 2013 console-efi
8021 -r--r--r--. 1 root root 56 Aug 13 2013 console-efi
8021 -r--r--r--. 1 root root 56 Aug 13 2013 console-efi
8021 -r--r--r--. 1 root root 56 Aug 13 2013 console-efi
8021 -r--r--r--. 1 root root 56 Aug 13 2013 console-efi
8021 -r--r--r--. 1 root root 56 Aug 13 2013 console-efi
8021 -r--r--r--. 1 root root 56 Aug 13 2013 console-efi
8021 -r--r--r--. 1 root root 56 Aug 13 2013 console-efi
8021 -r--r--r--. 1 root root 56 Aug 13 2013 console-efi

I can remove one, and then it gets even more weird:

[/sys/fs/pstore]1 rm console-efi
[/sys/fs/pstore]1 ls | wc
536 536 6432

Goodie - one less. Let's try again. 'rm c<tab>' completes to console-efi

[/sys/fs/pstore]1 rm console-efi
rm: cannot remove 'console-efi': No such file or directory
[/sys/fs/pstore] ls | wc
536 536 6432

[/sys/fs/pstore]1 ls -li console-efi
ls: cannot access console-efi: No such file or directory

[/sys/fs/pstore] ls -li 2>&1 | uniq -c
536 ls: cannot access console-efi: No such file or directory
1 total 0
536 ? -????????? ? ? ? ? ? console-efi

Any ideas?




Attachments:
(No filename) (848.00 B)

2014-04-09 21:02:08

by Tony Luck

[permalink] [raw]
Subject: Re: pstore wierdness on Dell Latitude E6530.

On Wed, Apr 9, 2014 at 11:20 AM, Valdis Kletnieks
<[email protected]> wrote:
> For some reason, /sys/fs/pstore has 537 files in it, all called 'console-efi',

> Any ideas?

Take a look at this thread: https://lkml.org/lkml/2013/10/30/83

I think there were some bugs in the console-efi code a while
back - perhaps you ran a kernel had the bug and made all these
duplicate entries?

-Tony

2014-04-10 16:51:30

by Valdis Klētnieks

[permalink] [raw]
Subject: Re: pstore wierdness on Dell Latitude E6530.

On Wed, 09 Apr 2014 14:02:04 -0700, Tony Luck said:

> Take a look at this thread: https://lkml.org/lkml/2013/10/30/83
>
> I think there were some bugs in the console-efi code a while
> back - perhaps you ran a kernel had the bug and made all these
> duplicate entries?

The cited patch pair isn't in linux-next-20140409, but applied with a few
1-line offsets. Boothing the result was much better. 'git blame' doesn't
indicate anything changed between next-0303 (busted) and next-0409, so
I have to conclude that Madper Xie's patch is an improvement.

Madper: Feel free to stick this on the patch:
Tested-By: Valdis Kletnieks <[email protected]>

The gory details:

I now have different filenames and inodes, with different contents, rather than
duplicates:

ls -li /sys/fs/pstore | head
total 0
8034 -r--r--r--. 1 root root 67 Aug 13 2013 console-efi-0-1376377513
8033 -r--r--r--. 1 root root 51 Aug 13 2013 console-efi-0-1376377515
8032 -r--r--r--. 1 root root 71 Aug 13 2013 console-efi-0-1376377517
8031 -r--r--r--. 1 root root 52 Aug 13 2013 console-efi-0-1376377519
8030 -r--r--r--. 1 root root 67 Aug 13 2013 console-efi-0-1376379570
8029 -r--r--r--. 1 root root 67 Aug 13 2013 console-efi-0-1376379650
8028 -r--r--r--. 1 root root 67 Aug 13 2013 console-efi-0-1376381002
8027 -r--r--r--. 1 root root 97 Aug 13 2013 console-efi-0-1376381189
8026 -r--r--r--. 1 root root 78 Aug 13 2013 console-efi-0-1376381190

grep . * | head
console-efi-0-1376377513:[ 4.423745] hda_codec: cannot build controls for #1 (error -16)
console-efi-0-1376377515:[ 6.245592] netconsole: network logging started
console-efi-0-1376377517:[ 6.676439] ata_id (211) used greatest stack depth: 4408 bytes left
console-efi-0-1376377519:[ 8.679546] sd 6:0:0:0: [sdb] Attached SCSI disk
console-efi-0-1376379570:[ 2.001350] hda_codec: cannot build controls for #3 (error -16)
console-efi-0-1376379650:[ 1.982463] hda_codec: cannot build controls for #3 (error -16)
console-efi-0-1376381002:[ 1.983509] hda_codec: cannot build controls for #3 (error -16)
console-efi-0-1376381189:[ 0.000000] efi: mem27: type=7, attr=0xf, range=[0x00000000be944000-0x00000000be951000) (0MB)
console-efi-0-1376381190:[ 0.620462] ACPI: PCI Interrupt Link [LNKE] (IRQs *3 4 5 6 10 11 12 14 15)
console-efi-0-1376381191:[ 3.890372] netconsole: network logging started

And 'rm *' actually removed all 536 remaining entries and they stayed removed.




Attachments:
(No filename) (848.00 B)