This chip is (nearly) identical to the Winbond w25m512jv which is
already supported by Linux. Compared to the w25m512jv, the 'jw'
has a different JEDEC ID.
Signed-off-by: Lad Prabhakar <[email protected]>
Reviewed-by: Biju Das <[email protected]>
---
drivers/mtd/spi-nor/winbond.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index 6dcde15fb1aa..b5dfc09fef30 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -88,6 +88,8 @@ static const struct flash_info winbond_parts[] = {
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
+ { "w25m512jw", INFO(0xef6119, 0, 64 * 1024, 1024,
+ SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
};
/**
--
2.17.1
On Fri, Oct 16, 2020 at 1:56 PM Lad Prabhakar
<[email protected]> wrote:
> This chip is (nearly) identical to the Winbond w25m512jv which is
> already supported by Linux. Compared to the w25m512jv, the 'jw'
> has a different JEDEC ID.
>
> Signed-off-by: Lad Prabhakar <[email protected]>
> Reviewed-by: Biju Das <[email protected]>
Datasheets available at
https://www.winbond.com/hq/product/code-storage-flash-memory/spistack-flash/?__locale=en&partNo=W25M512JV
https://www.winbond.com/hq/product/code-storage-flash-memory/spistack-flash/?__locale=en&partNo=W25M512JW
Reviewed-by: Geert Uytterhoeven <[email protected]>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On 10/16/20 5:25 PM, Lad Prabhakar wrote:
> This chip is (nearly) identical to the Winbond w25m512jv which is
> already supported by Linux. Compared to the w25m512jv, the 'jw'
> has a different JEDEC ID.
>
> Signed-off-by: Lad Prabhakar <[email protected]>
> Reviewed-by: Biju Das <[email protected]>
I believe this was tested on a real HW? Including Quad mode?
> ---
> drivers/mtd/spi-nor/winbond.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 6dcde15fb1aa..b5dfc09fef30 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -88,6 +88,8 @@ static const struct flash_info winbond_parts[] = {
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> + { "w25m512jw", INFO(0xef6119, 0, 64 * 1024, 1024,
> + SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> };
>
> /**
>
On Tue, Nov 10, 2020 at 12:58 PM Vignesh Raghavendra <[email protected]> wrote:
>
>
>
> On 10/16/20 5:25 PM, Lad Prabhakar wrote:
> > This chip is (nearly) identical to the Winbond w25m512jv which is
> > already supported by Linux. Compared to the w25m512jv, the 'jw'
> > has a different JEDEC ID.
> >
> > Signed-off-by: Lad Prabhakar <[email protected]>
> > Reviewed-by: Biju Das <[email protected]>
>
> I believe this was tested on a real HW? Including Quad mode?
>
Yes it's tested on Renesas RZ/G2M platform (attached is the log).
Cheers,
Prabhakar
Hi Tudor,
On Mon, Dec 7, 2020 at 5:27 PM <[email protected]> wrote:
>
> Hi, Lad,
>
> On 10/16/20 2:55 PM, Lad Prabhakar wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > This chip is (nearly) identical to the Winbond w25m512jv which is
> > already supported by Linux. Compared to the w25m512jv, the 'jw'
> > has a different JEDEC ID.
>
> W25M512JW-IQ (2 x 256M-bit) Serial MCP (Multi Chip Package) Flash memory,
> introduces a new “Software Die Select (C2h)” instruction, which we don't
> support. I guess you can't access the second die with what we have in
> mainline. Or am I wrong? We'll need to add support for multi-die support
> if we want to add new multi-die flashes.
>
My bad, yes only the first die is accessible. I'll post a patch
dropping this id.
Cheers,
Prabhakar