tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 17214b70a159c6547df9ae204a6275d983146f6b
commit: 8f0153ecd3bf184bc06afca25b737c707fa4d765 RISC-V: KVM: Add skeleton support for perf
config: riscv-randconfig-m031-20230319 (https://download.01.org/0day-ci/archive/20230321/[email protected]/config)
compiler: riscv32-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <[email protected]>
| Reported-by: Dan Carpenter <[email protected]>
| Link: https://lore.kernel.org/r/[email protected]/
smatch warnings:
arch/riscv/kvm/vcpu_pmu.c:40 kvm_riscv_vcpu_pmu_ctr_info() error: buffer overflow 'kvpmu->pmc' 64 <= 64
vim +40 arch/riscv/kvm/vcpu_pmu.c
8f0153ecd3bf184 Atish Patra 2023-02-07 30 int kvm_riscv_vcpu_pmu_ctr_info(struct kvm_vcpu *vcpu, unsigned long cidx,
8f0153ecd3bf184 Atish Patra 2023-02-07 31 struct kvm_vcpu_sbi_return *retdata)
8f0153ecd3bf184 Atish Patra 2023-02-07 32 {
8f0153ecd3bf184 Atish Patra 2023-02-07 33 struct kvm_pmu *kvpmu = vcpu_to_pmu(vcpu);
8f0153ecd3bf184 Atish Patra 2023-02-07 34
8f0153ecd3bf184 Atish Patra 2023-02-07 35 if (cidx > RISCV_KVM_MAX_COUNTERS || cidx == 1) {
Probably change > to >= RISCV_KVM_MAX_COUNTERS. It's strange that 1 is
invalid. I would have expected 0 to be invalid. (I have not looked at
the context outside this email).
8f0153ecd3bf184 Atish Patra 2023-02-07 36 retdata->err_val = SBI_ERR_INVALID_PARAM;
8f0153ecd3bf184 Atish Patra 2023-02-07 37 return 0;
8f0153ecd3bf184 Atish Patra 2023-02-07 38 }
8f0153ecd3bf184 Atish Patra 2023-02-07 39
8f0153ecd3bf184 Atish Patra 2023-02-07 @40 retdata->out_val = kvpmu->pmc[cidx].cinfo.value;
^^^^^^^^^^^^^^^^^
8f0153ecd3bf184 Atish Patra 2023-02-07 41
8f0153ecd3bf184 Atish Patra 2023-02-07 42 return 0;
8f0153ecd3bf184 Atish Patra 2023-02-07 43 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests