2019-09-08 12:55:56

by Souptick Joarder

Subject: [PATCH 2/3] xen/ballon: Avoid calling dummy function __online_page_set_limits()

__online_page_set_limits() is a dummy function and an extra call
to this function can be avoided.

Signed-off-by: Souptick Joarder <[email protected]>
---
drivers/xen/balloon.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index 4e11de6..05b1f7e 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -376,7 +376,6 @@ static void xen_online_page(struct page *page, unsigned int order)
mutex_lock(&balloon_mutex);
for (i = 0; i < size; i++) {
p = pfn_to_page(start_pfn + i);
- __online_page_set_limits(p);
__SetPageOffline(p);
__balloon_append(p);
}
--
1.9.1

2019-09-08 12:58:05

by Jürgen Groß

Subject: Re: [PATCH 2/3] xen/ballon: Avoid calling dummy function __online_page_set_limits()

On 07.09.19 23:47, Souptick Joarder wrote:
> __online_page_set_limits() is a dummy function and an extra call
> to this function can be avoided.
>
> Signed-off-by: Souptick Joarder <[email protected]>

Reviewed-by: Juergen Gross <[email protected]>


Juergen

2019-09-09 14:51:36

by David Hildenbrand

Subject: Re: [PATCH 2/3] xen/ballon: Avoid calling dummy function __online_page_set_limits()

On 07.09.19 23:47, Souptick Joarder wrote:
> __online_page_set_limits() is a dummy function and an extra call
> to this function can be avoided.
>
> Signed-off-by: Souptick Joarder <[email protected]>
> ---
> drivers/xen/balloon.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
> index 4e11de6..05b1f7e 100644
> --- a/drivers/xen/balloon.c
> +++ b/drivers/xen/balloon.c
> @@ -376,7 +376,6 @@ static void xen_online_page(struct page *page, unsigned int order)
> mutex_lock(&balloon_mutex);
> for (i = 0; i < size; i++) {
> p = pfn_to_page(start_pfn + i);
> - __online_page_set_limits(p);
> __SetPageOffline(p);
> __balloon_append(p);
> }
>

Reviewed-by: David Hildenbrand <[email protected]>

--

Thanks,

David / dhildenb