2016-03-17 14:25:53

by Maarten ter Huurne

[permalink] [raw]
Subject: Re: [PATCH 7/7] regulator: act8865: Init at subsys level

On Monday 29 February 2016 20:35:37 Mark Brown wrote:
> On Sun, Feb 28, 2016 at 04:53:29PM +0100, Maarten ter Huurne wrote:
> > Since the defined regulators are used in other drivers, we can avoid
> > deferred probing by registering this driver sooner.
>
> No, don't play silly link order games. We are never going to get a
> link order that avoids deferred probes, faffing about changing things
> to try to make one just leads to lots of noise. If you want to avoid
> noise from deferred probe then work on something that communicates
> dependencies to the driver core so we don't have to brute force
> things, Raphael has some ideas there he's been looking at.

On our device the LCD panel is powered by one of the ACT8600 outputs.
Avoiding the deferred probe means the screen turns on a couple of
seconds earlier.

I agree that the current hardcoded priority system is not ideal and a
dependency based system would be the right solution in the long term,
but I was looking for a short term solution with this patch.

In any case, I excluded this patch from the v2 series. I cleaned up the
register configuration (debugfs) patch, split the of_node patch into two
patches and resubmitted the redundant dev lookups patch. Thanks for
reviewing and please let me know if there is anything more that needs
changing.

Bye,
Maarten