2012-08-17 16:43:35

by Damien Lespiau

[permalink] [raw]
Subject: Re: [Intel-gfx] [PATCH 6/7] drm/i915: Disable FDI RX before FDI TX

On Tue, Aug 14, 2012 at 5:34 AM, Keith Packard <[email protected]> wrote:
> Doesn't make sense to disable in the other order.
>
> Signed-off-by: Keith Packard <[email protected]>
> ---
> drivers/gpu/drm/i915/intel_display.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)

I can't see anything in the docs about an order requirement for those.
Not sure why the other way does not make sense. Somehow disabling TX
before RX makes some sense to me (TX enabled without a ready RX looks
weird?, no data should flow as the pipe is shutdown at that point
anyway). Maybe it just does not matter?

Another detail is that disabling the PLLs seem to have an order in the
disabling sequence, TX, then RX.

I. Disable CPU FDI Transmitter PLL
II. Disable PCH FDI Receiver PLL

--
Damien