2021-09-07 16:16:18

by Tom Zanussi

[permalink] [raw]
Subject: [PATCH RT 1/3] locking/rwsem-rt: Remove might_sleep() in __up_read()

From: Andrew Halaney <[email protected]>

v5.4.143-rt64-rc2 stable review patch.
If anyone has any objections, please let me know.

-----------


[ Upstream commit b2ed0a4302faf2bb09e97529dd274233c082689b ]

There's no chance of sleeping here, the reader is giving up the
lock and possibly waking up the writer who is waiting on it.

Reported-by: Chunyu Hu <[email protected]>
Signed-off-by: Andrew Halaney <[email protected]>
Signed-off-by: Steven Rostedt (VMware) <[email protected]>
Signed-off-by: Tom Zanussi <[email protected]>
---
kernel/locking/rwsem-rt.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/kernel/locking/rwsem-rt.c b/kernel/locking/rwsem-rt.c
index 19ea20be3fd7..966946454ced 100644
--- a/kernel/locking/rwsem-rt.c
+++ b/kernel/locking/rwsem-rt.c
@@ -200,7 +200,6 @@ void __up_read(struct rw_semaphore *sem)
if (!atomic_dec_and_test(&sem->readers))
return;

- might_sleep();
raw_spin_lock_irq(&m->wait_lock);
/*
* Wake the writer, i.e. the rtmutex owner. It might release the
--
2.17.1