2023-06-08 19:19:34

by Christophe JAILLET

Subject: [PATCH 1/2] rtc: st-lpc: Release some resources in st_rtc_probe() in case of error

If an error occurs after clk_get(), the corresponding resources should be
released.

Use devm_clk_get() to fix it.

Fixes: b5b2bdfc2893 ("rtc: st: Add new driver for ST's LPC RTC")
Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/rtc/rtc-st-lpc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-st-lpc.c b/drivers/rtc/rtc-st-lpc.c
index 0f8e4231098e..d04d46f9cc65 100644
--- a/drivers/rtc/rtc-st-lpc.c
+++ b/drivers/rtc/rtc-st-lpc.c
@@ -228,7 +228,7 @@ static int st_rtc_probe(struct platform_device *pdev)
enable_irq_wake(rtc->irq);
disable_irq(rtc->irq);

- rtc->clk = clk_get(&pdev->dev, NULL);
+ rtc->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(rtc->clk)) {
dev_err(&pdev->dev, "Unable to request clock\n");
return PTR_ERR(rtc->clk);
--
2.34.1

2023-06-25 23:14:28

by Alexandre Belloni

Subject: Re: [PATCH 1/2] rtc: st-lpc: Release some resources in st_rtc_probe() in case of error

On Thu, 08 Jun 2023 21:11:42 +0200, Christophe JAILLET wrote:
> If an error occurs after clk_get(), the corresponding resources should be
> released.
>
> Use devm_clk_get() to fix it.
>
>

Applied, thanks!

[1/2] rtc: st-lpc: Release some resources in st_rtc_probe() in case of error
commit: 06c6e1b01d9261f03629cefd1f3553503291e6cf
[2/2] rtc: st-lpc: Simplify clk handling in st_rtc_probe()
commit: 0e6f36cca1bd3f5257315b55d9f31519ea4cc059

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com