2018-11-28 15:26:33

by Rafael Aquini

Subject: [PATCH] sysctl: clean up nr_pdflush_threads leftover

nr_pdflush_threads has been long deprecated and
removed, but a remnant of its glorious past is
still around in CTL_VM names enum. This patch
is a minor clean-up to that case.

Signed-off-by: Rafael Aquini <[email protected]>
---
include/uapi/linux/sysctl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/sysctl.h b/include/uapi/linux/sysctl.h
index d71013fffaf6..dad5a8f93343 100644
--- a/include/uapi/linux/sysctl.h
+++ b/include/uapi/linux/sysctl.h
@@ -174,7 +174,7 @@ enum
VM_DIRTY_RATIO=12, /* dirty_ratio */
VM_DIRTY_WB_CS=13, /* dirty_writeback_centisecs */
VM_DIRTY_EXPIRE_CS=14, /* dirty_expire_centisecs */
- VM_NR_PDFLUSH_THREADS=15, /* nr_pdflush_threads */
+ VM_UNUSED15=15, /* was: int nr_pdflush_threads */
VM_OVERCOMMIT_RATIO=16, /* percent of RAM to allow overcommit in */
VM_PAGEBUF=17, /* struct: Control pagebuf parameters */
VM_HUGETLB_PAGES=18, /* int: Number of available Huge Pages */
--
2.17.2

2018-11-29 14:12:22

by William Kucharski

Subject: Re: [PATCH] sysctl: clean up nr_pdflush_threads leftover

> On Nov 28, 2018, at 8:24 AM, Rafael Aquini <[email protected]> wrote:
>
> nr_pdflush_threads has been long deprecated and
> removed, but a remnant of its glorious past is
> still around in CTL_VM names enum. This patch
> is a minor clean-up to that case.
>
> Signed-off-by: Rafael Aquini <[email protected]>
> ---
> include/uapi/linux/sysctl.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/sysctl.h b/include/uapi/linux/sysctl.h
> index d71013fffaf6..dad5a8f93343 100644
> --- a/include/uapi/linux/sysctl.h
> +++ b/include/uapi/linux/sysctl.h
> @@ -174,7 +174,7 @@ enum
> VM_DIRTY_RATIO=12, /* dirty_ratio */
> VM_DIRTY_WB_CS=13, /* dirty_writeback_centisecs */
> VM_DIRTY_EXPIRE_CS=14, /* dirty_expire_centisecs */
> - VM_NR_PDFLUSH_THREADS=15, /* nr_pdflush_threads */
> + VM_UNUSED15=15, /* was: int nr_pdflush_threads */
> VM_OVERCOMMIT_RATIO=16, /* percent of RAM to allow overcommit in */
> VM_PAGEBUF=17, /* struct: Control pagebuf parameters */
> VM_HUGETLB_PAGES=18, /* int: Number of available Huge Pages */
> --
> 2.17.2
>

Please reword the comment to add a colon after the word "int" to match earlier
comments in the enum:

+ VM_UNUSED15=15, /* was: int: nr_pdflush_threads */

Also, as long as you're changing this file, please fix the typo earlier in the
same enum:

- VM_UNUSED2=2, /* was; int: Linear or sqrt() swapout for hogs */
+ VM_UNUSED2=2, /* was: int: Linear or sqrt() swapout for hogs */


Reviewed-by: William Kucharski <[email protected]>

2018-11-29 15:10:39

by Rafael Aquini

Subject: [PATCH v2] sysctl: clean up nr_pdflush_threads leftover

nr_pdflush_threads has been long deprecated and
removed, but a remnant of its glorious past is
still around in CTL_VM names enum. This patch
is a minor clean-up to that case.

Reviewed-by: William Kucharski <[email protected]>
Signed-off-by: Rafael Aquini <[email protected]>
---
v2:
- adjust typo "was;" for VM_UNUSED2 comment [wkucharski]
- add colon after "int" for VM_UNUSED15 comment [wkucharski]

include/uapi/linux/sysctl.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/uapi/linux/sysctl.h b/include/uapi/linux/sysctl.h
index d71013fffaf6..9df59925ed55 100644
--- a/include/uapi/linux/sysctl.h
+++ b/include/uapi/linux/sysctl.h
@@ -161,7 +161,7 @@ enum
enum
{
VM_UNUSED1=1, /* was: struct: Set vm swapping control */
- VM_UNUSED2=2, /* was; int: Linear or sqrt() swapout for hogs */
+ VM_UNUSED2=2, /* was: int: Linear or sqrt() swapout for hogs */
VM_UNUSED3=3, /* was: struct: Set free page thresholds */
VM_UNUSED4=4, /* Spare */
VM_OVERCOMMIT_MEMORY=5, /* Turn off the virtual memory safety limit */
@@ -174,7 +174,7 @@ enum
VM_DIRTY_RATIO=12, /* dirty_ratio */
VM_DIRTY_WB_CS=13, /* dirty_writeback_centisecs */
VM_DIRTY_EXPIRE_CS=14, /* dirty_expire_centisecs */
- VM_NR_PDFLUSH_THREADS=15, /* nr_pdflush_threads */
+ VM_UNUSED15=15, /* was: int: nr_pdflush_threads */
VM_OVERCOMMIT_RATIO=16, /* percent of RAM to allow overcommit in */
VM_PAGEBUF=17, /* struct: Control pagebuf parameters */
VM_HUGETLB_PAGES=18, /* int: Number of available Huge Pages */
--
2.17.2