2022-11-21 15:45:10

by Thomas Gleixner

[permalink] [raw]
Subject: [patch V2 03/40] irqchip/gic-v2m: Include arm-gic-common.h

W=1 build complains:

drivers/irqchip/irq-gic-v2m.c:570:12: warning: no previous prototype for ‘gicv2m_init’ [-Wmissing-prototypes]
570 | int __init gicv2m_init(struct fwnode_handle *parent_handle,

Signed-off-by: Thomas Gleixner <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Marc Zyngier <[email protected]>
---
drivers/irqchip/irq-gic-v2m.c | 1 +
1 file changed, 1 insertion(+)

--- a/drivers/irqchip/irq-gic-v2m.c
+++ b/drivers/irqchip/irq-gic-v2m.c
@@ -24,6 +24,7 @@
#include <linux/slab.h>
#include <linux/spinlock.h>
#include <linux/irqchip/arm-gic.h>
+#include <linux/irqchip/arm-gic-common.h>

/*
* MSI_TYPER:


2022-11-24 13:03:49

by Marc Zyngier

[permalink] [raw]
Subject: Re: [patch V2 03/40] irqchip/gic-v2m: Include arm-gic-common.h

On Mon, 21 Nov 2022 14:39:32 +0000,
Thomas Gleixner <[email protected]> wrote:
>
> W=1 build complains:
>
> drivers/irqchip/irq-gic-v2m.c:570:12: warning: no previous prototype for ‘gicv2m_init’ [-Wmissing-prototypes]
> 570 | int __init gicv2m_init(struct fwnode_handle *parent_handle,
>
> Signed-off-by: Thomas Gleixner <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Marc Zyngier <[email protected]>

Acked-by: Marc Zyngier <[email protected]>

M.

--
Without deviation from the norm, progress is not possible.

Subject: [tip: irq/core] irqchip/gic-v2m: Include arm-gic-common.h

The following commit has been merged into the irq/core branch of tip:

Commit-ID: 72a3f8f22a36aaf05da8941535d1c553fe049b2b
Gitweb: https://git.kernel.org/tip/72a3f8f22a36aaf05da8941535d1c553fe049b2b
Author: Thomas Gleixner <[email protected]>
AuthorDate: Mon, 21 Nov 2022 15:39:32 +01:00
Committer: Thomas Gleixner <[email protected]>
CommitterDate: Tue, 06 Dec 2022 12:50:17 +01:00

irqchip/gic-v2m: Include arm-gic-common.h

W=1 build complains:

drivers/irqchip/irq-gic-v2m.c:570:12: warning: no previous prototype for ‘gicv2m_init’ [-Wmissing-prototypes]
570 | int __init gicv2m_init(struct fwnode_handle *parent_handle,

Signed-off-by: Thomas Gleixner <[email protected]>
Acked-by: Marc Zyngier <[email protected]>
Link: https://lore.kernel.org/r/[email protected]

---
drivers/irqchip/irq-gic-v2m.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c
index 6e1ac33..fcc871a 100644
--- a/drivers/irqchip/irq-gic-v2m.c
+++ b/drivers/irqchip/irq-gic-v2m.c
@@ -24,6 +24,7 @@
#include <linux/slab.h>
#include <linux/spinlock.h>
#include <linux/irqchip/arm-gic.h>
+#include <linux/irqchip/arm-gic-common.h>

/*
* MSI_TYPER: