2006-11-25 01:37:04

by Lu, Yinghai

[permalink] [raw]
Subject: [PATCH 2/2] x86-64: change the size for interrupt array to NR_VECTORS

Please check the patch.


Attachments:
(No filename) (24.00 B)
i8259.patch (869.00 B)
Download all attachments

2006-11-25 06:59:48

by Eric W. Biederman

[permalink] [raw]
Subject: Re: [PATCH 2/2] x86-64: change the size for interrupt array to NR_VECTORS

"Yinghai Lu" <[email protected]> writes:

> Please check the patch.

YH. Please place a newline between your subject and your description
in the body of your patches.

> [PATCH] x86_64: interrupt array size should be aligned to NR_VECTORS
>
> interrupt array is referred for idt vectors instead of NR_IRQS, so change size
> to NR_VECTORS - FIRST_EXTERNAL_VECTOR. Also change to static.
>
> Signed-off-by: Yinghai Lu <[email protected]>

Acked-by: Eric Biederman <[email protected]>

Yep I missed this optimization opportunity :)

Eric

2006-11-25 08:40:48

by Lu, Yinghai

[permalink] [raw]
Subject: Re: [PATCH 2/2] x86-64: change the size for interrupt array to NR_VECTORS

On 11/24/06, Eric W. Biederman <[email protected]> wrote:
> "Yinghai Lu" <[email protected]> writes:
> YH. Please place a newline between your subject and your description
> in the body of your patches.

Next time.

> Yep I missed this optimization opportunity :)

You did a great job to clean up the irq_vector mapping.

YH

2006-11-25 08:57:17

by Eric W. Biederman

[permalink] [raw]
Subject: Re: [PATCH 2/2] x86-64: change the size for interrupt array to NR_VECTORS

"Yinghai Lu" <[email protected]> writes:

> On 11/24/06, Eric W. Biederman <[email protected]> wrote:
>> "Yinghai Lu" <[email protected]> writes:
>> YH. Please place a newline between your subject and your description
>> in the body of your patches.
>
> Next time.
>
>> Yep I missed this optimization opportunity :)
>
> You did a great job to clean up the irq_vector mapping.

Yep and created many new optimization and clean up opportunities...
Because I didn't take everything to it's full logical conclusion :)

Just enough to make everything architecture specific.

Eric